Re: [PATCH v4] mm, sysctl: make NUMA stats configurable

2017-10-17 Thread Michal Hocko
On Tue 17-10-17 16:03:44, kemi wrote: > On 2017年10月17日 15:54, Michal Hocko wrote: [...] > > So basically any value will enable numa stats. This means that we would > > never be able to extend this interface to e.g. auto mode (say value 2). > > I guess you meant to check sysctl_vm_numa_stat == ENABL

Re: [PATCH v4] mm, sysctl: make NUMA stats configurable

2017-10-17 Thread kemi
On 2017年10月17日 15:54, Michal Hocko wrote: > On Tue 17-10-17 09:20:58, Kemi Wang wrote: > [...] > > Other than two remarks below, it looks good to me and it also looks > simpler. > >> diff --git a/mm/vmstat.c b/mm/vmstat.c >> index 4bb13e7..e746ed1 100644 >> --- a/mm/vmstat.c >> +++ b/mm/vmstat.

Re: [PATCH v4] mm, sysctl: make NUMA stats configurable

2017-10-17 Thread Michal Hocko
On Tue 17-10-17 09:20:58, Kemi Wang wrote: [...] Other than two remarks below, it looks good to me and it also looks simpler. > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 4bb13e7..e746ed1 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -32,6 +32,76 @@ > > #define NUMA_STATS_THRESHOLD (

[PATCH v4] mm, sysctl: make NUMA stats configurable

2017-10-16 Thread Kemi Wang
This is the second step which introduces a tunable interface that allow numa stats configurable for optimizing zone_statistics(), as suggested by Dave Hansen and Ying Huang. = When page allocation performance becomes a bottlen