Hi Pavel,
On Tue, Dec 13, 2016 at 10:05:06PM +0100, Pavel Machek wrote:
> Hi!
>
> I have finally found the old mail you were refering to. Let me go
> through it.
>
> > > +/*
> > > + * Convert exposure time `us' to rows. Modify `us' to make it to
> > > + * correspond to the actual exposure time.
Hi!
I have finally found the old mail you were refering to. Let me go
through it.
> > +/*
> > + * Convert exposure time `us' to rows. Modify `us' to make it to
> > + * correspond to the actual exposure time.
> > + */
> > +static int et8ek8_exposure_us_to_rows(struct et8ek8_sensor *sensor, u32
>
Hi!
> > + /* V4L2_CID_EXPOSURE */
> > + min = et8ek8_exposure_rows_to_us(sensor, 1);
> > + max = et8ek8_exposure_rows_to_us(sensor,
> > + sensor->current_reglist->mode.max_exp);
>
> Haven't I suggested to use lines instead? I vaguely remember doing so...
> this wou
Hi!
> > +static void et8ek8_reglist_to_mbus(const struct et8ek8_reglist *reglist,
> > + struct v4l2_mbus_framefmt *fmt)
> > +{
> > + fmt->width = reglist->mode.window_width;
> > + fmt->height = reglist->mode.window_height;
> > +
> > + if (reglist->mode.pixel_form
Hi!
> > + u32 min, max;
> > +
> > + v4l2_ctrl_handler_init(&sensor->ctrl_handler, 4);
> > +
> > + /* V4L2_CID_GAIN */
> > + v4l2_ctrl_new_std(&sensor->ctrl_handler, &et8ek8_ctrl_ops,
> > + V4L2_CID_GAIN, 0, ARRAY_SIZE(et8ek8_gain_table) - 1,
> > + 1,
Hi!
> Just a few more comments...
>
> Please check my other review as well. I believe you may have missed the
> comments in between in that one.
Sorry for that. Would you have a link for that email or a copy? (I
can't seem to find it.)
Thanks,
Hi Pavel,
Just a few more comments...
Please check my other review as well. I believe you may have missed the
comments in between in that one.
On Sun, Oct 23, 2016 at 10:03:55PM +0200, Pavel Machek wrote:
>
> Add driver for et8ek8 sensor, found in Nokia N900 main camera. Can be
> used for takin
Hi Pavel,
On Tue, Nov 15, 2016 at 11:54:25AM +0100, Pavel Machek wrote:
> Hi!
>
> > On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote:
> > > > > Thanks, this answered half of my questions already. ;-)
> > > > :-).
> > > >
> > > > I'll have to go through the patches, et8ek8 driver is p
Hi!
> On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote:
> > > > Thanks, this answered half of my questions already. ;-)
> > > :-).
> > >
> > > I'll have to go through the patches, et8ek8 driver is probably not
> > > enough to get useful video. platform/video-bus-switch.c is needed for
Hi Sakari,
On Mon, Nov 14, 2016 at 11:58:28PM +0200, Sakari Ailus wrote:
> [...]
>
> On Fri, Nov 04, 2016 at 01:05:25AM +0100, Sebastian Reichel wrote:
> > I'm not sure what part relevant for video-bus-switch is currently
> > not supported?
> >
> > video-bus-switch registers its own async notifie
Hi Sebastian,
On Fri, Nov 04, 2016 at 01:05:25AM +0100, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Nov 04, 2016 at 01:05:01AM +0200, Sakari Ailus wrote:
> > On Thu, Nov 03, 2016 at 11:48:43PM +0100, Sebastian Reichel wrote:
> > > On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote:
> > >
Hi,
On Fri, Nov 04, 2016 at 01:05:01AM +0200, Sakari Ailus wrote:
> On Thu, Nov 03, 2016 at 11:48:43PM +0100, Sebastian Reichel wrote:
> > On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote:
> > > > > Thanks, this answered half of my questions already. ;-)
> > > > :-).
> > > >
> > > > I
Hi,
On 4.11.2016 01:05, Sakari Ailus wrote:
Hi Sebastian,
On Thu, Nov 03, 2016 at 11:48:43PM +0100, Sebastian Reichel wrote:
Hi,
On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote:
Thanks, this answered half of my questions already. ;-)
:-).
I'll have to go through the patches,
Hi Sebastian,
On Thu, Nov 03, 2016 at 11:48:43PM +0100, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote:
> > > > Thanks, this answered half of my questions already. ;-)
> > > :-).
> > >
> > > I'll have to go through the patches, et8ek8 driver is pr
Hi,
On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote:
> > > Thanks, this answered half of my questions already. ;-)
> > :-).
> >
> > I'll have to go through the patches, et8ek8 driver is probably not
> > enough to get useful video. platform/video-bus-switch.c is needed for
> > camera
Hi!
> > > > I'll have to go through the patches, et8ek8 driver is probably not
> > > > enough to get useful video. platform/video-bus-switch.c is needed for
> > > > camera switching, then some omap3isp patches to bind flash and
> > > > autofocus into the subdevice.
> > > >
> > > > Then, device tr
On 2.11.2016 10:15, Pavel Machek wrote:
Hi!
I'll have to go through the patches, et8ek8 driver is probably not
enough to get useful video. platform/video-bus-switch.c is needed for
camera switching, then some omap3isp patches to bind flash and
autofocus into the subdevice.
Then, device tree
Hi!
> >>I'll have to go through the patches, et8ek8 driver is probably not
> >>enough to get useful video. platform/video-bus-switch.c is needed for
> >>camera switching, then some omap3isp patches to bind flash and
> >>autofocus into the subdevice.
> >>
> >>Then, device tree support on n900 can b
Hello,
On Tuesday 01 Nov 2016 00:58:45 Sakari Ailus wrote:
> On Sun, Oct 23, 2016 at 10:40:01PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > > Thanks, this answered half of my questions already. ;-)
> > >
> > > Do all the modes work for you currently btw.?
> >
> > Aha, went through my notes. This
On 1.11.2016 22:11, Sakari Ailus wrote:
Hi Ivaylo,
On Tue, Nov 01, 2016 at 08:36:57AM +0200, Ivaylo Dimitrov wrote:
Hi,
On 1.11.2016 00:54, Sakari Ailus wrote:
Hi Pavel,
On Sun, Oct 23, 2016 at 10:33:15PM +0200, Pavel Machek wrote:
Hi!
Thanks, this answered half of my questions alread
Hi Pavel,
On Tue, Nov 01, 2016 at 04:39:21PM +0100, Pavel Machek wrote:
> Hi!
>
> > > I'll have to go through the patches, et8ek8 driver is probably not
> > > enough to get useful video. platform/video-bus-switch.c is needed for
> > > camera switching, then some omap3isp patches to bind flash and
Hi Ivaylo,
On Tue, Nov 01, 2016 at 08:36:57AM +0200, Ivaylo Dimitrov wrote:
> Hi,
>
> On 1.11.2016 00:54, Sakari Ailus wrote:
> >Hi Pavel,
> >
> >On Sun, Oct 23, 2016 at 10:33:15PM +0200, Pavel Machek wrote:
> >>Hi!
> >>
> >>>Thanks, this answered half of my questions already. ;-)
> >>
> >>:-).
Hi!
> > I'll have to go through the patches, et8ek8 driver is probably not
> > enough to get useful video. platform/video-bus-switch.c is needed for
> > camera switching, then some omap3isp patches to bind flash and
> > autofocus into the subdevice.
> >
> > Then, device tree support on n900 can b
Hi,
On 1.11.2016 00:54, Sakari Ailus wrote:
Hi Pavel,
On Sun, Oct 23, 2016 at 10:33:15PM +0200, Pavel Machek wrote:
Hi!
Thanks, this answered half of my questions already. ;-)
:-).
I'll have to go through the patches, et8ek8 driver is probably not
enough to get useful video. platform/vid
Hi Pavel,
(Cc Laurent.)
On Sun, Oct 23, 2016 at 10:40:01PM +0200, Pavel Machek wrote:
> Hi!
>
> > Thanks, this answered half of my questions already. ;-)
> >
> > Do all the modes work for you currently btw.?
>
> Aha, went through my notes. This is what it does in 5MP mode, even on
> v4.9:
>
>
Hi Pavel,
On Sun, Oct 23, 2016 at 10:33:15PM +0200, Pavel Machek wrote:
> Hi!
>
> > Thanks, this answered half of my questions already. ;-)
>
> :-).
>
> I'll have to go through the patches, et8ek8 driver is probably not
> enough to get useful video. platform/video-bus-switch.c is needed for
> c
On Sun 2016-10-23 23:19:54, Sakari Ailus wrote:
> Hi Pavel,
>
> Thanks, this answered half of my questions already. ;-)
>
> Do all the modes work for you currently btw.?
I pushed current kernel sources to kernel.org:
git push
g...@gitolite.kernel.org:pub/scm/linux/kernel/git/pavel/linux-n900.gi
Hi!
> Thanks, this answered half of my questions already. ;-)
>
> Do all the modes work for you currently btw.?
Aha, went through my notes. This is what it does in 5MP mode, even on
v4.9:
pavel@n900:/my/fcam-dev$ ./camera.py
['-r']
['-l', '"et8ek8 3-003e":0 -> "video-bus-switch":1 [1]']
['-l',
Hi!
> Thanks, this answered half of my questions already. ;-)
:-).
I'll have to go through the patches, et8ek8 driver is probably not
enough to get useful video. platform/video-bus-switch.c is needed for
camera switching, then some omap3isp patches to bind flash and
autofocus into the subdevice.
Hi Pavel,
Thanks, this answered half of my questions already. ;-)
Do all the modes work for you currently btw.?
On Sun, Oct 23, 2016 at 10:03:55PM +0200, Pavel Machek wrote:
>
> Add driver for et8ek8 sensor, found in Nokia N900 main camera. Can be
> used for taking photos in 2.5MP resolution wi
Add driver for et8ek8 sensor, found in Nokia N900 main camera. Can be
used for taking photos in 2.5MP resolution with fcam-dev.
Signed-off-by: Ivaylo Dimitrov
Signed-off-by: Pavel Machek
---
From v4 I did cleanups to coding style and removed various oddities.
diff --git a/drivers/media/i2c/Kc
31 matches
Mail list logo
