Re: [PATCH v4] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-12 Thread Johan Hovold
On Thu, Jun 12, 2014 at 01:48:41AM +0300, Janne Kanniainen wrote: > This driver adds support for USB controlled led panels that exists in MSI > GT683R laptop You forgot to break this line. > > Signed-off-by: Janne Kanniainen > --- > Changes in v2: > - sorted headers to alphabetic order

[PATCH v4] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-11 Thread Janne Kanniainen
This driver adds support for USB controlled led panels that exists in MSI GT683R laptop Signed-off-by: Janne Kanniainen --- Changes in v2: - sorted headers to alphabetic order - using devm_kzalloc - using BIT(n) - using usb_control_msg instead of usb_submit_urb