Re: [PATCH v4] cpufreq: intel_pstate: Reporting reasons why driver prematurely exit

2019-02-13 Thread Erwan Velu
Le 13/02/2019 à 11:34, Rafael J. Wysocki a écrit : > So a single "no PCCH" message for this whole function should be sufficient. Let's do that. [...] > And what did turn out to be the problem? > > Anyway, pr_info() should be sufficient IMO. You should be pretty aware of 95d6c0857e54b78898274607

Re: [PATCH v4] cpufreq: intel_pstate: Reporting reasons why driver prematurely exit

2019-02-13 Thread Rafael J. Wysocki
On Wed, Feb 13, 2019 at 10:13 AM Erwan Velu wrote: > > > Le 13/02/2019 à 00:01, Rafael J. Wysocki a écrit : > [...] > > Newline characters are missing in all of your messages. > > oops. Fixing this. > > > "ACPI _PSS not found\n" > > Done. > > > >> return true; > >> } > >> > >> @@ -2484,

Re: [PATCH v4] cpufreq: intel_pstate: Reporting reasons why driver prematurely exit

2019-02-13 Thread Erwan Velu
Le 13/02/2019 à 00:01, Rafael J. Wysocki a écrit : [...] > Newline characters are missing in all of your messages. oops. Fixing this. > "ACPI _PSS not found\n" Done. >> return true; >> } >> >> @@ -2484,10 +2485,15 @@ static bool __init intel_pstate_no_acpi_pcch(void) >> ac

Re: [PATCH v4] cpufreq: intel_pstate: Reporting reasons why driver prematurely exit

2019-02-12 Thread Rafael J. Wysocki
On Tue, Feb 12, 2019 at 8:09 AM Erwan Velu wrote: > > The init code path has several exceptions where the module can decide not to > load. > As CONFIG_X86_INTEL_PSTATE is generally set to Y, the return code is not > reachable. > The initialization code is neither verbose of the reason why it did

[PATCH v4] cpufreq: intel_pstate: Reporting reasons why driver prematurely exit

2019-02-11 Thread Erwan Velu
The init code path has several exceptions where the module can decide not to load. As CONFIG_X86_INTEL_PSTATE is generally set to Y, the return code is not reachable. The initialization code is neither verbose of the reason why it did choose to prematurely exit. This situation leads to a situat