Re: [PATCH v4] clk: add CS2000 Fractional-N driver

2015-10-15 Thread Stephen Boyd
On 10/15, Kuninori Morimoto wrote: > > I understand. If my understanding is correct, user driver > setups/enables this clock. > If so, I still want this "clock-frequency" feature. > because this clock requests other clock on my board. > And requested clock requests this clock too. > Thus, these cl

Re: [PATCH v4] clk: add CS2000 Fractional-N driver

2015-10-14 Thread Kuninori Morimoto
Hi Stephen > > Can I confirm ? > > Does this "i2c device down" means call i2c_set_clientdata() > > in this function ? > > I mean passing a struct device pointer to this function and then > using it here in the clk_register() function. I understand. will fix in v5 > > > > +static int cs2000_clk_

Re: [PATCH v4] clk: add CS2000 Fractional-N driver

2015-10-02 Thread Stephen Boyd
On 10/02, Kuninori Morimoto wrote: > > Hi Stephen > > Thank you for your review > > > > + init.parent_names = parent_names; > > > + init.num_parents= ARRAY_SIZE(parent_names); > > > + > > > + priv->hw.init = &init; > > > + > > > + clk = clk_register(NULL, &priv->hw); > > > > How a

Re: [PATCH v4] clk: add CS2000 Fractional-N driver

2015-10-01 Thread Kuninori Morimoto
Hi Stephen Thank you for your review > > + init.parent_names = parent_names; > > + init.num_parents= ARRAY_SIZE(parent_names); > > + > > + priv->hw.init = &init; > > + > > + clk = clk_register(NULL, &priv->hw); > > How about using devm_clk_register() and passing the i2c de

Re: [PATCH v4] clk: add CS2000 Fractional-N driver

2015-10-01 Thread Stephen Boyd
On 09/15, Kuninori Morimoto wrote: > + > +static int cs2000_clk_register(struct cs2000_priv *priv) > +{ > + struct device *dev = priv_to_dev(priv); > + struct device_node *np = dev->of_node; > + struct clk_init_data init; > + const char *name = np->name; > + struct clk *clk; > +

[PATCH v4] clk: add CS2000 Fractional-N driver

2015-09-15 Thread Kuninori Morimoto
From: Kuninori Morimoto This patch adds CS2000 Fractional-N driver as clock provider. Signed-off-by: Kuninori Morimoto --- v3 -> v4 - clk_ops base - add #clock-cells on document - drop 0x from example - add "." on document - drop parentheses - care of_clk_add_provider() fail case - clk_