Re: [PATCH v4] checkpatch: extend attributes check to handle more patterns

2020-10-25 Thread Joe Perches
On Sun, 2020-10-25 at 14:12 +0530, Dwaipayan Ray wrote: > Suppose we have non handled attributes in one such > multi attribute macro. (not present in our hash) > > Like __attribute__((__packed, __something_not_handled)) > > For this case, do I skip the warning totally? Or something else? Emit th

Re: [PATCH v4] checkpatch: extend attributes check to handle more patterns

2020-10-25 Thread Dwaipayan Ray
On Sun, Oct 25, 2020 at 2:08 PM Joe Perches wrote: > > On Sun, 2020-10-25 at 14:02 +0530, Dwaipayan Ray wrote: > > And also do you think there should be a separate check > > for __alias__(#symbol)? I think it expects a string and that should > > be trimmed in the fix. > > For now, I think you shou

Re: [PATCH v4] checkpatch: extend attributes check to handle more patterns

2020-10-25 Thread Joe Perches
On Sun, 2020-10-25 at 14:02 +0530, Dwaipayan Ray wrote: > And also do you think there should be a separate check > for __alias__(#symbol)? I think it expects a string and that should > be trimmed in the fix. For now, I think you should avoid both alias and section. There are patches to convert bo

Re: [PATCH v4] checkpatch: extend attributes check to handle more patterns

2020-10-25 Thread Dwaipayan Ray
On Sun, Oct 25, 2020 at 1:52 PM Joe Perches wrote: > > On Sun, 2020-10-25 at 12:21 +0530, Dwaipayan Ray wrote: > > It is generally preferred that the macros from > > include/linux/compiler_attributes.h are used, unless there > > is a reason not to. > > > > checkpatch currently checks __attribute__

Re: [PATCH v4] checkpatch: extend attributes check to handle more patterns

2020-10-25 Thread Joe Perches
On Sun, 2020-10-25 at 12:21 +0530, Dwaipayan Ray wrote: > It is generally preferred that the macros from > include/linux/compiler_attributes.h are used, unless there > is a reason not to. > > checkpatch currently checks __attribute__ for each of > packed, aligned, printf, scanf, and weak. Other de

[PATCH v4] checkpatch: extend attributes check to handle more patterns

2020-10-24 Thread Dwaipayan Ray
It is generally preferred that the macros from include/linux/compiler_attributes.h are used, unless there is a reason not to. checkpatch currently checks __attribute__ for each of packed, aligned, printf, scanf, and weak. Other declarations in compiler_attributes.h are not handled. Add a generic