Re: [PATCH v4] KSM: numa awareness sysfs knob

2012-10-08 Thread Petr Holasek
Hi Hugh, first of all, please let me apologize for the delay in my response and thank you for your extensive review! On Sun, 30 Sep 2012, Hugh Dickins wrote: > Andrea's point about ksm_migrate_page() is an important one, and I've > answered that against his mail, but here's some other easier poin

Re: [PATCH v4] KSM: numa awareness sysfs knob

2012-10-01 Thread Hugh Dickins
On Mon, 1 Oct 2012, Andrea Arcangeli wrote: > On Sun, Sep 30, 2012 at 05:36:33PM -0700, Hugh Dickins wrote: > > I'm all for the simplest solution, but here in ksm_migrate_page() > > is not a good place for COW breaking - we don't want to get into > > an indefinite number of page allocations, and th

Re: [PATCH v4] KSM: numa awareness sysfs knob

2012-10-01 Thread Andrea Arcangeli
Hi Hugh, On Sun, Sep 30, 2012 at 05:36:33PM -0700, Hugh Dickins wrote: > I'm all for the simplest solution, but here in ksm_migrate_page() > is not a good place for COW breaking - we don't want to get into > an indefinite number of page allocations, and the risk of failure. Agreed, not a good pla

Re: [PATCH v4] KSM: numa awareness sysfs knob

2012-10-01 Thread Hugh Dickins
On Sun, 30 Sep 2012, Hugh Dickins wrote: > Andrea's point about ksm_migrate_page() is an important one, and I've > answered that against his mail, but here's some other easier points. There's another point that I completely forgot to make once I got down to the details of your patch. Somewhere, I

Re: [PATCH v4] KSM: numa awareness sysfs knob

2012-09-30 Thread Hugh Dickins
Andrea's point about ksm_migrate_page() is an important one, and I've answered that against his mail, but here's some other easier points. On Mon, 24 Sep 2012, Petr Holasek wrote: > Introduces new sysfs boolean knob /sys/kernel/mm/ksm/merge_across_nodes > which control merging pages across differ

Re: [PATCH v4] KSM: numa awareness sysfs knob

2012-09-30 Thread Hugh Dickins
Sorry for taking so long to look at Petr's nice work: it's more than what I can think through in odd stolen moments; but yesterday at last I managed to get down to remembering KSM and giving this some time. On Fri, 28 Sep 2012, Andrea Arcangeli wrote: > On Mon, Sep 24, 2012 at 02:56:06AM +0200, Pe

Re: [PATCH v4] KSM: numa awareness sysfs knob

2012-09-28 Thread Andrea Arcangeli
Hi everyone, On Mon, Sep 24, 2012 at 02:56:06AM +0200, Petr Holasek wrote: > +static struct rb_root root_unstable_tree[MAX_NUMNODES] = { RB_ROOT, }; not initializing is better so we don't waste .data and it goes in the .bss, initializing only the first entry is useless anyway, that's getting init

Re: [PATCH v4] KSM: numa awareness sysfs knob

2012-09-27 Thread Rik van Riel
On 09/23/2012 08:56 PM, Petr Holasek wrote: Introduces new sysfs boolean knob /sys/kernel/mm/ksm/merge_across_nodes which control merging pages across different numa nodes. When it is set to zero only pages from the same node are merged, otherwise pages from all nodes can be merged together (defa

[PATCH v4] KSM: numa awareness sysfs knob

2012-09-23 Thread Petr Holasek
Introduces new sysfs boolean knob /sys/kernel/mm/ksm/merge_across_nodes which control merging pages across different numa nodes. When it is set to zero only pages from the same node are merged, otherwise pages from all nodes can be merged together (default behavior). Typical use-case could be a lo