On Tue, Jul 11, 2017 at 11:57:10PM -0700, Nick Desaulniers wrote:
> Hi Dmitry, did you get a chance to merge the sugguested revision, yet?
Sorry, no, as it was broken (we lost the assignment to the bytes 2 and
3 of the PS/2 data stream). Here is the version that seems to work, but
at this time I g
Hi Dmitry, did you get a chance to merge the sugguested revision, yet?
On Sun, Jun 25, 2017 at 11:06:09AM -0700, Dmitry Torokhov wrote:
> Hi Nick,
>
> Since the time the code was written we got nice helpers to clamp the
> values. Does the following work for you or it still leaves clang
> unhappy?
LGTM, no more warnings with Clang.
Hi Nick,
On Mon, May 29, 2017 at 10:41:51PM -0700, Nick Desaulniers wrote:
> Clang warns:
>
> drivers/input/mousedev.c:653:63: error: implicit conversion from 'int'
> to 'signed char' changes value from 200 to -56
> [-Wconstant-conversion]
> client->ps2[1] = 0x60; client->ps2[2] = 3; client->ps
Hi Dmitry, did you have more feedback for this patch?
ping for re-review
Clang warns:
drivers/input/mousedev.c:653:63: error: implicit conversion from 'int'
to 'signed char' changes value from 200 to -56
[-Wconstant-conversion]
client->ps2[1] = 0x60; client->ps2[2] = 3; client->ps2[3] = 200;
~ ^~~
As far as
7 matches
Mail list logo
