Re: [PATCH v3 net-next] xfrm: Add check to prevent un-complete key manager

2013-11-11 Thread David Miller
From: baker.ker...@gmail.com Date: Mon, 11 Nov 2013 14:39:11 +0800 > + if (km->acquire == NULL || km->compile_policy == NULL) > + return -EINVAL; There are 7 function pointer methods that must be fully implemented in an xfrm_mgr object, not just two. And really we absolutely do n

Re: [PATCH v3 net-next] xfrm: Add check to prevent un-complete key manager

2013-11-10 Thread Fan Du
On 2013年11月11日 14:39, baker.ker...@gmail.com wrote: From: Baker Zhang "acquire" and "compile_policy" callbacks are necessary for a key manager. Signed-off-by: Baker Zhang --- Thanks for all reply. V1: For current kernel source, there is no problem. In our vpn product, we need a xfrm_km in k

[PATCH v3 net-next] xfrm: Add check to prevent un-complete key manager

2013-11-10 Thread baker . kernel
From: Baker Zhang "acquire" and "compile_policy" callbacks are necessary for a key manager. Signed-off-by: Baker Zhang --- Thanks for all reply. V1: For current kernel source, there is no problem. In our vpn product, we need a xfrm_km in kernel module to monitor the xfrm state change. thus, t