Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)

2014-08-08 Thread Christoph Lameter
On Fri, 8 Aug 2014, Geert Uytterhoeven wrote: > > Ok this is broken on m68k. CONFIG_NUMA is required for this to work. If > > the arch code does this despite !CONFIG_NUMA then lots of things should > > break. > > Can you please elaborate? We've been using for years... !CONFIG_NUMA leads to the as

Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)

2014-08-08 Thread Geert Uytterhoeven
Hi Christoph, On Fri, Aug 8, 2014 at 1:50 PM, Christoph Lameter wrote: > On Fri, 8 Aug 2014, Geert Uytterhoeven wrote: >> > Of possible, could you check whether page_to_nid(page) returns >> > only 0 or not? >> >> It returns 0 or 1. > > Ok this is broken on m68k. CONFIG_NUMA is required for this t

Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)

2014-08-08 Thread Christoph Lameter
On Fri, 8 Aug 2014, Geert Uytterhoeven wrote: > > > Of possible, could you check whether page_to_nid(page) returns > > only 0 or not? > > It returns 0 or 1. Ok this is broken on m68k. CONFIG_NUMA is required for this to work. If the arch code does this despite !CONFIG_NUMA then lots of things sho

Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)

2014-08-08 Thread Geert Uytterhoeven
Hi Joonsoo, On Fri, Aug 8, 2014 at 9:19 AM, Joonsoo Kim wrote: > Could you show me your full dmesg on boot-up? > What I want to know is nodes-cpus mapping. Attached. If you want more debug output, please ask. > I looked at SLAB code and found that SLAB works fine only if > numa_mem_id() always

Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)

2014-08-08 Thread Joonsoo Kim
On Thu, Aug 07, 2014 at 10:03:09PM +0900, Joonsoo Kim wrote: > 2014-08-07 21:53 GMT+09:00 Geert Uytterhoeven : > > Hi, > > > > On Thu, Aug 7, 2014 at 2:36 PM, Joonsoo Kim wrote: > >>> With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM: > >>> > >>> enable_cpucache failed for rad

Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)

2014-08-07 Thread Joonsoo Kim
2014-08-07 21:53 GMT+09:00 Geert Uytterhoeven : > Hi, > > On Thu, Aug 7, 2014 at 2:36 PM, Joonsoo Kim wrote: >>> With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM: >>> >>> enable_cpucache failed for radix_tree_node, error 12. >>> kernel BUG at /scratch/geert/linux/linux-m68k/m

Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)

2014-08-07 Thread Geert Uytterhoeven
Hi, On Thu, Aug 7, 2014 at 2:36 PM, Joonsoo Kim wrote: >> With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM: >> >> enable_cpucache failed for radix_tree_node, error 12. >> kernel BUG at /scratch/geert/linux/linux-m68k/mm/slab.c:1522! >> I bisected it to commit a640616822b2c3

Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)

2014-08-07 Thread Joonsoo Kim
2014-08-07 20:52 GMT+09:00 Geert Uytterhoeven : > Hi Joonsoo, > > On Tue, Jul 1, 2014 at 10:27 AM, Joonsoo Kim wrote: >> BAD_ALIEN_MAGIC value isn't used anymore. So remove it. >> >> Acked-by: Christoph Lameter >> Signed-off-by: Joonsoo Kim >> --- >> mm/slab.c |4 +--- >> 1 file changed, 1

BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)

2014-08-07 Thread Geert Uytterhoeven
Hi Joonsoo, On Tue, Jul 1, 2014 at 10:27 AM, Joonsoo Kim wrote: > BAD_ALIEN_MAGIC value isn't used anymore. So remove it. > > Acked-by: Christoph Lameter > Signed-off-by: Joonsoo Kim > --- > mm/slab.c |4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/slab.c b/mm

[PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC

2014-07-01 Thread Joonsoo Kim
BAD_ALIEN_MAGIC value isn't used anymore. So remove it. Acked-by: Christoph Lameter Signed-off-by: Joonsoo Kim --- mm/slab.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/slab.c b/mm/slab.c index 7820a45..60c9e11 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -470,8 +4