Re: [PATCH v3 8/8] cpufreq: intel_pstate: Use CPPC to get max performance

2016-09-12 Thread Srinivas Pandruvada
On Sat, 2016-09-10 at 18:22 +0200, Thomas Gleixner wrote: > On Thu, 8 Sep 2016, Srinivas Pandruvada wrote: [...] > > 20 lines of magic logic w/o a userful comment. Darn, you yourself > will have > forgotten the magic within 3 month > Valid points. Will take care in the next patchset. Than

Re: [PATCH v3 8/8] cpufreq: intel_pstate: Use CPPC to get max performance

2016-09-10 Thread Thomas Gleixner
On Thu, 8 Sep 2016, Srinivas Pandruvada wrote: > + > +/* Call set_sched_itmt from a work function to be able to use hotplug locks > */ And why can't the function below not do that? Is the reader required to figure that out himslf? > +static void intel_pstste_sched_itmt_work_fn(struct work_struct

[PATCH v3 8/8] cpufreq: intel_pstate: Use CPPC to get max performance

2016-09-08 Thread Srinivas Pandruvada
This change uses acpi cppc_lib interface to get CPPC performance limits. Once CPPC limits of all online cores are read, first check if there is difference in max performance. If there is a difference, then the scheduler interface is called to update per cpu priority. After updating priority of all