Re: [PATCH v3 7/8] mm/mempolicy: use a standard migration target allocation callback

2020-10-09 Thread Mike Kravetz
On 10/9/20 3:23 PM, Hugh Dickins wrote: > On Fri, 9 Oct 2020, Mike Kravetz wrote: >> On 10/8/20 10:50 PM, Hugh Dickins wrote: >>> >>> It's a problem I've faced before in tmpfs, keeping a hold on the >>> mapping while page lock is dropped. Quite awkward: igrab() looks as >>> if it's the right thing

Re: [PATCH v3 7/8] mm/mempolicy: use a standard migration target allocation callback

2020-10-09 Thread Hugh Dickins
On Fri, 9 Oct 2020, Mike Kravetz wrote: > On 10/8/20 10:50 PM, Hugh Dickins wrote: > > > > It's a problem I've faced before in tmpfs, keeping a hold on the > > mapping while page lock is dropped. Quite awkward: igrab() looks as > > if it's the right thing to use, but turns out to give no protecti

Re: [PATCH v3 7/8] mm/mempolicy: use a standard migration target allocation callback

2020-10-09 Thread Mike Kravetz
On 10/8/20 10:50 PM, Hugh Dickins wrote: > On Thu, 8 Oct 2020, Mike Kravetz wrote: >> On 10/7/20 8:21 PM, Hugh Dickins wrote: >>> >>> Mike, j'accuse... your 5.7 commit c0d0381ade79 ("hugetlbfs: >>> use i_mmap_rwsem for more pmd sharing synchronization"), in which >>> unmap_and_move_huge_page() now

Re: [PATCH v3 7/8] mm/mempolicy: use a standard migration target allocation callback

2020-10-08 Thread Hugh Dickins
On Thu, 8 Oct 2020, Mike Kravetz wrote: > On 10/7/20 8:21 PM, Hugh Dickins wrote: > > > > Mike, j'accuse... your 5.7 commit c0d0381ade79 ("hugetlbfs: > > use i_mmap_rwsem for more pmd sharing synchronization"), in which > > unmap_and_move_huge_page() now passes the TTU_RMAP_LOCKED flag to > > try_

Re: [PATCH v3 7/8] mm/mempolicy: use a standard migration target allocation callback

2020-10-08 Thread Mike Kravetz
On 10/7/20 8:21 PM, Hugh Dickins wrote: > On Tue, 7 Jul 2020, Qian Cai wrote: >> On Tue, Jun 23, 2020 at 03:13:47PM +0900, js1...@gmail.com wrote: >>> From: Joonsoo Kim >>> >>> There is a well-defined migration target allocation callback. >>> Use it. >>> >>> Signed-off-by: Joonsoo Kim >>> --- > .

Re: [PATCH v3 7/8] mm/mempolicy: use a standard migration target allocation callback

2020-10-07 Thread Hugh Dickins
On Tue, 7 Jul 2020, Qian Cai wrote: > On Tue, Jun 23, 2020 at 03:13:47PM +0900, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > There is a well-defined migration target allocation callback. > > Use it. > > > > Signed-off-by: Joonsoo Kim > > --- ... > > migrate_pages() starts failing like

Re: [PATCH v3 7/8] mm/mempolicy: use a standard migration target allocation callback

2020-07-07 Thread Michal Hocko
On Tue 07-07-20 21:20:44, Qian Cai wrote: [...] > migrate_pages() starts failing like this apparently using the new > callback on NUMA systems, > > [ 6147.019063][T45242] LTP: starting move_pages12 > [ 6147.475680][T64921] BUG: unable to handle page fault for address: > ffe0 Hmm, thi

Re: [PATCH v3 7/8] mm/mempolicy: use a standard migration target allocation callback

2020-07-07 Thread Qian Cai
On Tue, Jun 23, 2020 at 03:13:47PM +0900, js1...@gmail.com wrote: > From: Joonsoo Kim > > There is a well-defined migration target allocation callback. > Use it. > > Signed-off-by: Joonsoo Kim > --- > mm/internal.h | 1 - > mm/mempolicy.c | 30 ++ > mm/migrate.c

Re: [PATCH v3 7/8] mm/mempolicy: use a standard migration target allocation callback

2020-07-03 Thread Vlastimil Babka
On 6/23/20 8:13 AM, js1...@gmail.com wrote: > From: Joonsoo Kim > > There is a well-defined migration target allocation callback. > Use it. > > Signed-off-by: Joonsoo Kim Acked-by: Vlastimil Babka I like that this removes the wrapper completely.

Re: [PATCH v3 7/8] mm/mempolicy: use a standard migration target allocation callback

2020-06-25 Thread Michal Hocko
On Tue 23-06-20 15:13:47, Joonsoo Kim wrote: > From: Joonsoo Kim > > There is a well-defined migration target allocation callback. > Use it. > > Signed-off-by: Joonsoo Kim Acked-by: Michal Hocko > --- > mm/internal.h | 1 - > mm/mempolicy.c | 30 ++ > mm/migrat

[PATCH v3 7/8] mm/mempolicy: use a standard migration target allocation callback

2020-06-22 Thread js1304
From: Joonsoo Kim There is a well-defined migration target allocation callback. Use it. Signed-off-by: Joonsoo Kim --- mm/internal.h | 1 - mm/mempolicy.c | 30 ++ mm/migrate.c | 8 ++-- 3 files changed, 12 insertions(+), 27 deletions(-) diff --git a/mm/in