Re: [PATCH v3 7/7] remoteproc: qcom: Always assert and deassert reset signals in SDM845

Hi Bjorn, Thanks for the review On 03/19/2018 04:16 AM, Bjorn Andersson wrote: On Wed 14 Mar 02:21 PDT 2018, Sibi S wrote: diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c [..] +struct q6v5_reset_ops { + int (*reset_start)(struct q6v5 *qproc); +

Re: [PATCH v3 7/7] remoteproc: qcom: Always assert and deassert reset signals in SDM845

On Wed 14 Mar 02:21 PDT 2018, Sibi S wrote: > diff --git a/drivers/remoteproc/qcom_q6v5_pil.c > b/drivers/remoteproc/qcom_q6v5_pil.c [..] > +struct q6v5_reset_ops { > + int (*reset_start)(struct q6v5 *qproc); > + int (*reset_stop)(struct q6v5 *qproc); > +}; Please add these two ops direct

[PATCH v3 7/7] remoteproc: qcom: Always assert and deassert reset signals in SDM845

SDM845 brings a new reset signal ALT_RESET which is a part of the MSS subsystem hence requires some of the active clks to be enabled before assert/deassert Reset the modem if the BOOT FSM does timeout Reset assert/deassert sequence vary across SoCs adding reset, adding start/stop helper functions