Re: [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout

2019年5月13日(月) 16:41 Minwoo Im : > > > -static void __maybe_unused nvme_coredump_init(struct nvme_dev *dev); > > -static void __maybe_unused nvme_coredump_logs(struct nvme_dev *dev); > > -static void __maybe_unused nvme_coredump_complete(struct nvme_dev > > *dev); > > +static void nvme_coredump_init

Re: [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout

On Sun, May 12, 2019 at 08:54:16AM -0700, Akinobu Mita wrote: > @@ -2536,6 +2539,9 @@ static void nvme_reset_work(struct work_struct *work) > if (result) > goto out; > > + nvme_coredump_logs(dev); If you change nvme_coredump_logs to return an int, check it here for < 0 an

Re: [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout

> -static void __maybe_unused nvme_coredump_init(struct nvme_dev *dev); > -static void __maybe_unused nvme_coredump_logs(struct nvme_dev *dev); > -static void __maybe_unused nvme_coredump_complete(struct nvme_dev > *dev); > +static void nvme_coredump_init(struct nvme_dev *dev); > +static void nvme_

[PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout

This enables the nvme driver to trigger a device coredump when command timeout occurs, and it helps diagnose and debug issues. This can be tested with fail_io_timeout fault injection. # echo 1 > /sys/kernel/debug/fail_io_timeout/probability # echo 1 > /sys/kernel/debug/fail_io_tim