Re: [PATCH v3 5/9] media: hantro: Introduce G2/HEVC decoder

2021-02-26 Thread Ezequiel Garcia
On Fri, 2021-02-26 at 10:47 +0100, Benjamin Gaignard wrote: > > Le 25/02/2021 à 18:55, Ezequiel Garcia a écrit : > > Hi Benjamin, > > > > Thanks for the good work! > > I mostly have two concerns with this implementation, > > the tiled output and the allocation path. > > > > More below. > > > >

Re: [PATCH v3 5/9] media: hantro: Introduce G2/HEVC decoder

2021-02-26 Thread Benjamin Gaignard
Le 25/02/2021 à 18:55, Ezequiel Garcia a écrit : Hi Benjamin, Thanks for the good work! I mostly have two concerns with this implementation, the tiled output and the allocation path. More below. On Mon, 2021-02-22 at 13:24 +0100, Benjamin Gaignard wrote: Implement all the logic to get G2 ha

Re: [PATCH v3 5/9] media: hantro: Introduce G2/HEVC decoder

2021-02-25 Thread Ezequiel Garcia
Hi Benjamin, Thanks for the good work! I mostly have two concerns with this implementation, the tiled output and the allocation path. More below. On Mon, 2021-02-22 at 13:24 +0100, Benjamin Gaignard wrote: > Implement all the logic to get G2 hardware decoding HEVC frames. > It support up level 5

[PATCH v3 5/9] media: hantro: Introduce G2/HEVC decoder

2021-02-22 Thread Benjamin Gaignard
Implement all the logic to get G2 hardware decoding HEVC frames. It support up level 5.1 HEVC stream. It doesn't support yet 10 bits formats or scaling feature. Add HANTRO HEVC dedicated control to skip some bits at the beginning of the slice header. That is very specific to this hardware so can't