Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-10-11 Thread Jonathan Neuschäfer
On Sun, Oct 04, 2020 at 10:42:09AM +0200, Alexandre Belloni wrote: > On 04/10/2020 03:43:23+0200, Jonathan Neuschäfer wrote: > > > > +static int ntxec_set_time(struct device *dev, struct rtc_time *tm) > > > > + res = regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_MINUTE, > > > > ntxec_re

Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-10-05 Thread Uwe Kleine-König
Hello Jonathan, On Sun, Oct 04, 2020 at 03:43:23AM +0200, Jonathan Neuschäfer wrote: > On Fri, Sep 25, 2020 at 07:44:24AM +0200, Uwe Kleine-König wrote: > > > +static struct platform_driver ntxec_rtc_driver = { > > > + .driver = { > > > + .name = "ntxec-rtc", > > > + }, > > > + .probe = nt

Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-10-04 Thread Alexandre Belloni
On 04/10/2020 03:43:23+0200, Jonathan Neuschäfer wrote: > > > +static int ntxec_set_time(struct device *dev, struct rtc_time *tm) > > > +{ > > > + struct ntxec_rtc *rtc = dev_get_drvdata(dev); > > > + int res = 0; > > > + > > > + res = regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_YEAR, > > > ntxe

Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-10-03 Thread Jonathan Neuschäfer
On Fri, Sep 25, 2020 at 07:44:24AM +0200, Uwe Kleine-König wrote: > Hello Jonathan, > > On Thu, Sep 24, 2020 at 09:24:53PM +0200, Jonathan Neuschäfer wrote: > > +#define NTXEC_REG_WRITE_YEAR 0x10 > > +#define NTXEC_REG_WRITE_MONTH 0x11 > > +#define NTXEC_REG_WRITE_DAY0x12 > > +#

Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-10-02 Thread Jonathan Neuschäfer
On Thu, Sep 24, 2020 at 10:40:11PM +0200, Andreas Kemnade wrote: > On Thu, 24 Sep 2020 21:24:53 +0200 > Jonathan Neuschäfer wrote: [...] > > +static struct platform_driver ntxec_rtc_driver = { > > + .driver = { > > + .name = "ntxec-rtc", > > + }, > > + .probe = ntxec_rtc_probe, > >

Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-09-25 Thread Jonathan Neuschäfer
On Fri, Sep 25, 2020 at 11:36:14AM +0200, Alexandre Belloni wrote: > Hi, > > On 24/09/2020 21:24:53+0200, Jonathan Neuschäfer wrote: ... > > v3: ... > > - Relicense as GPLv2 or later > > I don't think you had to relicense. The kernel is GPL 2 only, you are > free to license your code under GPL 2

Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-09-25 Thread Alexandre Belloni
Hi, On 24/09/2020 21:24:53+0200, Jonathan Neuschäfer wrote: > With this driver, mainline Linux can keep its time and date in sync with > the vendor kernel. > > Advanced functionality like alarm and automatic power-on is not yet > supported. > > Signed-off-by: Jonathan Neuschäfer > --- > > v3:

Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-09-24 Thread Uwe Kleine-König
Hello Jonathan, On Thu, Sep 24, 2020 at 09:24:53PM +0200, Jonathan Neuschäfer wrote: > +#define NTXEC_REG_WRITE_YEAR 0x10 > +#define NTXEC_REG_WRITE_MONTH0x11 > +#define NTXEC_REG_WRITE_DAY 0x12 > +#define NTXEC_REG_WRITE_HOUR 0x13 > +#define NTXEC_REG_WRITE_MINUTE 0x14 > +#define N

Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-09-24 Thread Andreas Kemnade
On Thu, 24 Sep 2020 21:24:53 +0200 Jonathan Neuschäfer wrote: > With this driver, mainline Linux can keep its time and date in sync with > the vendor kernel. > > Advanced functionality like alarm and automatic power-on is not yet > supported. > > Signed-off-by: Jonathan Neuschäfer > --- > > v

[PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-09-24 Thread Jonathan Neuschäfer
With this driver, mainline Linux can keep its time and date in sync with the vendor kernel. Advanced functionality like alarm and automatic power-on is not yet supported. Signed-off-by: Jonathan Neuschäfer --- v3: - Add email address to copyright line - Remove OF compatible string and don't inc