Re: [PATCH v3 5/7] kprobes/x86: Fix %p uses in error messages

On Fri, 27 Apr 2018 08:58:17 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > (addr < (u8 *) jprobe_return_end)) { > > if (stack_addr(regs) != saved_sp) { > > struct pt_regs *saved_regs = &kcb->jprobe_saved_regs; > > - print

Re: [PATCH v3 5/7] kprobes/x86: Fix %p uses in error messages

* Masami Hiramatsu wrote: > (addr < (u8 *) jprobe_return_end)) { > if (stack_addr(regs) != saved_sp) { > struct pt_regs *saved_regs = &kcb->jprobe_saved_regs; > - printk(KERN_ERR > -"current sp %p does

[PATCH v3 5/7] kprobes/x86: Fix %p uses in error messages

Fix %p uses in error messages in kprobes/x86. - Some %p uses are not needed. Just remove it (or remove message). - One %p use seems important to show some address so replaced with %pS. Signed-off-by: Masami Hiramatsu --- Changes in v3: - Do not use %px. --- arch/x86/kernel/kprobes/core.c |