Re: [PATCH v3 5/5] x86/sgx: Remove redundant if conditions in sgx_encl_create

2021-02-01 Thread Tianjia Zhang
On 1/30/21 10:33 PM, Jarkko Sakkinen wrote: On Sun, Jan 24, 2021 at 02:29:07PM +0800, Tianjia Zhang wrote: In this scenario, there is no case where va_page is NULL, and the error has been checked. The if condition statement here is redundant, so remove the condition detection. Signed-off-by:

Re: [PATCH v3 5/5] x86/sgx: Remove redundant if conditions in sgx_encl_create

2021-01-30 Thread Jarkko Sakkinen
On Sun, Jan 24, 2021 at 02:29:07PM +0800, Tianjia Zhang wrote: > In this scenario, there is no case where va_page is NULL, and > the error has been checked. The if condition statement here is > redundant, so remove the condition detection. > > Signed-off-by: Tianjia Zhang > --- > arch/x86/kernel

Re: [PATCH v3 5/5] x86/sgx: Remove redundant if conditions in sgx_encl_create

2021-01-26 Thread Sean Christopherson
On Sun, Jan 24, 2021, Greg KH wrote: > On Sun, Jan 24, 2021 at 02:29:07PM +0800, Tianjia Zhang wrote: > > In this scenario, there is no case where va_page is NULL, and > > the error has been checked. The if condition statement here is > > redundant, so remove the condition detection. > > > > Signe

Re: [PATCH v3 5/5] x86/sgx: Remove redundant if conditions in sgx_encl_create

2021-01-24 Thread Greg KH
On Sun, Jan 24, 2021 at 02:29:07PM +0800, Tianjia Zhang wrote: > In this scenario, there is no case where va_page is NULL, and > the error has been checked. The if condition statement here is > redundant, so remove the condition detection. > > Signed-off-by: Tianjia Zhang > --- > arch/x86/kernel

[PATCH v3 5/5] x86/sgx: Remove redundant if conditions in sgx_encl_create

2021-01-23 Thread Tianjia Zhang
In this scenario, there is no case where va_page is NULL, and the error has been checked. The if condition statement here is redundant, so remove the condition detection. Signed-off-by: Tianjia Zhang --- arch/x86/kernel/cpu/sgx/ioctl.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-