Re: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232

2015-01-29 Thread Sergei Shtylyov
Hello. On 1/29/2015 5:01 AM, Peter Hung wrote: Hello. Please don't top-post. I had using "scripts/checkpatch.pl -f" to scan original f81232.c. It reported with "quoted string split across lines", so I merge these 2 strings into 1 in patch 1/5. Seems like another unrelated change...

Re: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232

2015-01-28 Thread Peter Hung
Hello. I had using "scripts/checkpatch.pl -f" to scan original f81232.c. It reported with "quoted string split across lines", so I merge these 2 strings into 1 in patch 1/5. But it still warning with "line over 80 character", so I had shorted string with this line. I will refine my patch set a

Re: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232

2015-01-28 Thread Sergei Shtylyov
Hello. On 1/28/2015 8:58 AM, Peter Hung wrote: This patch implement CMSPAR in set_termios, and fix some warnning from checkpatch.pl Please don't try to do 2 unrelated things in one patch. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 21 +++-- 1 file ch

[PATCH v3 5/5] usb: serial: implement CMSPAR for F81232

2015-01-27 Thread Peter Hung
This patch implement CMSPAR in set_termios, and fix some warnning from checkpatch.pl Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c inde