Re: [PATCH v3 5/5] tracing/probe: Support user-space dereference

2019-02-28 Thread Steven Rostedt
On Thu, 28 Feb 2019 16:00:55 +0900 Masami Hiramatsu wrote: > > > > "+u0(%si):string will read a string from the address in the register > > %si that is expected to be in user-space. 'ustring' is a shortcut way > > off performing the same task. That is, +0(%si):ustring is equivalent > > to +u0

Re: [PATCH v3 5/5] tracing/probe: Support user-space dereference

2019-02-27 Thread Masami Hiramatsu
Hi Steve, Thank you for the review. On Wed, 27 Feb 2019 21:31:32 -0500 Steven Rostedt wrote: > On Wed, 27 Feb 2019 23:44:42 +0900 > Masami Hiramatsu wrote: > > > > > +.. _user_mem_access: > > +User Memory Access > > +-- > > +Kprobe events supports user-space memory access. F

Re: [PATCH v3 5/5] tracing/probe: Support user-space dereference

2019-02-27 Thread Masami Hiramatsu
On Wed, 27 Feb 2019 21:42:45 -0500 Steven Rostedt wrote: > On Wed, 27 Feb 2019 23:44:42 +0900 > Masami Hiramatsu wrote: > > > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c > > index a7012de37a00..0efef172db17 100644 > > --- a/kernel/trace/trace_probe.c > > +++ b/kernel/tr

Re: [PATCH v3 5/5] tracing/probe: Support user-space dereference

2019-02-27 Thread Steven Rostedt
On Wed, 27 Feb 2019 23:44:42 +0900 Masami Hiramatsu wrote: > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c > index a7012de37a00..0efef172db17 100644 > --- a/kernel/trace/trace_probe.c > +++ b/kernel/trace/trace_probe.c > @@ -239,6 +239,7 @@ parse_probe_arg(char *arg, const

Re: [PATCH v3 5/5] tracing/probe: Support user-space dereference

2019-02-27 Thread Steven Rostedt
On Wed, 27 Feb 2019 23:44:42 +0900 Masami Hiramatsu wrote: > > +.. _user_mem_access: > +User Memory Access > +-- > +Kprobe events supports user-space memory access. For that purpose, you can > use > +either user-space dereference syntax or 'ustring' type. > + > +user-space dere

[PATCH v3 5/5] tracing/probe: Support user-space dereference

2019-02-27 Thread Masami Hiramatsu
Support user-space dereference syntax for probe event arguments to dereference the data-structure or array in user-space. The syntax is just adding 'u' before an offset value. +|-u() e.g. +u8(%ax), +u0(+0(%si)) For example, if you probe do_sched_setscheduler(pid, policy, param) and record para