Re: [PATCH v3 5/5] firmware: fix fw cache to avoid usermode helper on suspend

2016-09-02 Thread Luis R. Rodriguez
On Wed, Aug 31, 2016 at 09:03:53AM +0200, Daniel Wagner wrote: > Hi Luis, > > On 08/24/2016 02:45 AM, mcg...@kernel.org wrote: > >diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c > >index 22d1760a4278..dca4f9cbf4db 100644 > >--- a/drivers/base/firmware_class.c > >+++ b/dr

Re: [PATCH v3 5/5] firmware: fix fw cache to avoid usermode helper on suspend

2016-08-31 Thread Daniel Wagner
Hi Luis, On 08/24/2016 02:45 AM, mcg...@kernel.org wrote: diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 22d1760a4278..dca4f9cbf4db 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -1412,7 +1412,7 @@ static int cache_firmware(con

[PATCH v3 5/5] firmware: fix fw cache to avoid usermode helper on suspend

2016-08-23 Thread mcgrof
From: "Luis R. Rodriguez" The firmware cache purposely kills all non-udev (usermode helper) pending requests prior to suspend with kill_requests_without_uevent() right before it calls out to request for firmware for the fw cache. It is pointless to again run into the possible issue of queing up f