Re: [PATCH v3 5/5] ext4: Defer mmap cmtime update until writeback

2013-08-19 Thread Dave Chinner
On Mon, Aug 19, 2013 at 08:30:02PM -0700, Andy Lutomirski wrote: > On Mon, Aug 19, 2013 at 7:38 PM, Dave Chinner wrote: > > On Fri, Aug 16, 2013 at 04:22:12PM -0700, Andy Lutomirski wrote: > >> A fancier implementation could probably avoid an extra journal > >> transaction by adding a mapping_test

Re: [PATCH v3 5/5] ext4: Defer mmap cmtime update until writeback

2013-08-19 Thread Andy Lutomirski
On Mon, Aug 19, 2013 at 7:38 PM, Dave Chinner wrote: > On Fri, Aug 16, 2013 at 04:22:12PM -0700, Andy Lutomirski wrote: >> A fancier implementation could probably avoid an extra journal >> transaction by adding a mapping_test_clear_cmtime call in >> ext4_writepages, but this should already be a co

Re: [PATCH v3 5/5] ext4: Defer mmap cmtime update until writeback

2013-08-19 Thread Dave Chinner
On Fri, Aug 16, 2013 at 04:22:12PM -0700, Andy Lutomirski wrote: > A fancier implementation could probably avoid an extra journal > transaction by adding a mapping_test_clear_cmtime call in > ext4_writepages, but this should already be a considerable > improvement -- we'll start one transaction per

[PATCH v3 5/5] ext4: Defer mmap cmtime update until writeback

2013-08-16 Thread Andy Lutomirski
A fancier implementation could probably avoid an extra journal transaction by adding a mapping_test_clear_cmtime call in ext4_writepages, but this should already be a considerable improvement -- we'll start one transaction per writepages call instead of one per page. Signed-off-by: Andy Lutomirski