Re: [PATCH v3 4/8] mm/hugetlb: make hugetlb migration callback CMA aware

2020-06-30 Thread Mike Kravetz
On 6/30/20 12:22 AM, Joonsoo Kim wrote: > 2020년 6월 30일 (화) 오후 3:42, Michal Hocko 님이 작성: >> >> On Tue 30-06-20 15:30:04, Joonsoo Kim wrote: >>> 2020년 6월 29일 (월) 오후 4:55, Michal Hocko 님이 작성: >> [...] diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 57ece74e3aae..c1595b1d36f3 100644 --- a

Re: [PATCH v3 4/8] mm/hugetlb: make hugetlb migration callback CMA aware

2020-06-30 Thread Joonsoo Kim
2020년 6월 30일 (화) 오후 3:42, Michal Hocko 님이 작성: > > On Tue 30-06-20 15:30:04, Joonsoo Kim wrote: > > 2020년 6월 29일 (월) 오후 4:55, Michal Hocko 님이 작성: > [...] > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > > index 57ece74e3aae..c1595b1d36f3 100644 > > > --- a/mm/hugetlb.c > > > +++ b/mm/hugetlb.c > >

Re: [PATCH v3 4/8] mm/hugetlb: make hugetlb migration callback CMA aware

2020-06-29 Thread Michal Hocko
On Tue 30-06-20 15:30:04, Joonsoo Kim wrote: > 2020년 6월 29일 (월) 오후 4:55, Michal Hocko 님이 작성: [...] > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 57ece74e3aae..c1595b1d36f3 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -1092,10 +1092,14 @@ static struct page > > *dequeue_huge

Re: [PATCH v3 4/8] mm/hugetlb: make hugetlb migration callback CMA aware

2020-06-29 Thread Joonsoo Kim
2020년 6월 29일 (월) 오후 4:55, Michal Hocko 님이 작성: > > On Mon 29-06-20 15:27:25, Joonsoo Kim wrote: > [...] > > Solution that Introduces a new > > argument doesn't cause this problem while avoiding CMA regions. > > My primary argument is that there is no real reason to treat hugetlb > dequeing somehow d

Re: [PATCH v3 4/8] mm/hugetlb: make hugetlb migration callback CMA aware

2020-06-29 Thread Michal Hocko
On Mon 29-06-20 15:27:25, Joonsoo Kim wrote: [...] > Solution that Introduces a new > argument doesn't cause this problem while avoiding CMA regions. My primary argument is that there is no real reason to treat hugetlb dequeing somehow differently. So if we simply exclude __GFP_MOVABLE for _any_ o

Re: [PATCH v3 4/8] mm/hugetlb: make hugetlb migration callback CMA aware

2020-06-29 Thread Joonsoo Kim
2020년 6월 26일 (금) 오후 4:23, Michal Hocko 님이 작성: > > On Fri 26-06-20 13:49:15, Joonsoo Kim wrote: > > 2020년 6월 25일 (목) 오후 8:54, Michal Hocko 님이 작성: > > > > > > On Tue 23-06-20 15:13:44, Joonsoo Kim wrote: > > > > From: Joonsoo Kim > > > > > > > > new_non_cma_page() in gup.c which try to allocate migr

Re: [PATCH v3 4/8] mm/hugetlb: make hugetlb migration callback CMA aware

2020-06-26 Thread Michal Hocko
On Fri 26-06-20 13:49:15, Joonsoo Kim wrote: > 2020년 6월 25일 (목) 오후 8:54, Michal Hocko 님이 작성: > > > > On Tue 23-06-20 15:13:44, Joonsoo Kim wrote: > > > From: Joonsoo Kim > > > > > > new_non_cma_page() in gup.c which try to allocate migration target page > > > requires to allocate the new page that

Re: [PATCH v3 4/8] mm/hugetlb: make hugetlb migration callback CMA aware

2020-06-25 Thread Joonsoo Kim
2020년 6월 25일 (목) 오후 8:54, Michal Hocko 님이 작성: > > On Tue 23-06-20 15:13:44, Joonsoo Kim wrote: > > From: Joonsoo Kim > > > > new_non_cma_page() in gup.c which try to allocate migration target page > > requires to allocate the new page that is not on the CMA area. > > new_non_cma_page() implements

Re: [PATCH v3 4/8] mm/hugetlb: make hugetlb migration callback CMA aware

2020-06-25 Thread Michal Hocko
On Tue 23-06-20 15:13:44, Joonsoo Kim wrote: > From: Joonsoo Kim > > new_non_cma_page() in gup.c which try to allocate migration target page > requires to allocate the new page that is not on the CMA area. > new_non_cma_page() implements it by removing __GFP_MOVABLE flag. This way > works well fo

[PATCH v3 4/8] mm/hugetlb: make hugetlb migration callback CMA aware

2020-06-22 Thread js1304
From: Joonsoo Kim new_non_cma_page() in gup.c which try to allocate migration target page requires to allocate the new page that is not on the CMA area. new_non_cma_page() implements it by removing __GFP_MOVABLE flag. This way works well for THP page or normal page but not for hugetlb page. huge