Re: [PATCH v3 4/6] floppy: properly handle failure on add_disk loop

2012-08-27 Thread Herton Ronaldo Krzesinski
On Tue, Aug 14, 2012 at 11:43:11AM -0300, Herton Ronaldo Krzesinski wrote: > On Tue, Aug 14, 2012 at 04:31:23AM +0100, Ben Hutchings wrote: > > On Mon, 2012-08-13 at 15:16 -0300, Herton Ronaldo Krzesinski wrote: > > > On do_floppy_init, if something failed inside the loop we call add_disk, > > > th

Re: [PATCH v3 4/6] floppy: properly handle failure on add_disk loop

2012-08-14 Thread Herton Ronaldo Krzesinski
On Tue, Aug 14, 2012 at 04:31:23AM +0100, Ben Hutchings wrote: > On Mon, 2012-08-13 at 15:16 -0300, Herton Ronaldo Krzesinski wrote: > > On do_floppy_init, if something failed inside the loop we call add_disk, > > there was no cleanup of previous iterations in the error handling. > > > > Cc: sta..

Re: [PATCH v3 4/6] floppy: properly handle failure on add_disk loop

2012-08-13 Thread Ben Hutchings
On Mon, 2012-08-13 at 15:16 -0300, Herton Ronaldo Krzesinski wrote: > On do_floppy_init, if something failed inside the loop we call add_disk, > there was no cleanup of previous iterations in the error handling. > > Cc: sta...@vger.kernel.org > Acked-by: Vivek Goyal > Signed-off-by: Herton Ronald

[PATCH v3 4/6] floppy: properly handle failure on add_disk loop

2012-08-13 Thread Herton Ronaldo Krzesinski
On do_floppy_init, if something failed inside the loop we call add_disk, there was no cleanup of previous iterations in the error handling. Cc: sta...@vger.kernel.org Acked-by: Vivek Goyal Signed-off-by: Herton Ronaldo Krzesinski --- drivers/block/floppy.c | 10 +- 1 file changed, 9 i