Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

2015-01-19 Thread Linus Walleij
On Thu, Jan 15, 2015 at 1:23 AM, Stephen Boyd wrote: > On 01/14/2015 03:54 PM, Timur Tabi wrote: >> On Wed, Jan 14, 2015 at 5:44 PM, Stephen Boyd wrote: >>> I think so. Can you send a patch? Plus it would be nice to move i = 0 in >>> the for loop at the same time. >> Sadly, Qualcomm policy makes

Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

2015-01-14 Thread Stephen Boyd
On 01/14/2015 03:54 PM, Timur Tabi wrote: > On Wed, Jan 14, 2015 at 5:44 PM, Stephen Boyd wrote: >> I think so. Can you send a patch? Plus it would be nice to move i = 0 in >> the for loop at the same time. > Sadly, Qualcomm policy makes that very cumbersome for me. I won't be > able to send a pa

Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

2015-01-14 Thread Timur Tabi
On Wed, Jan 14, 2015 at 5:44 PM, Stephen Boyd wrote: > > I think so. Can you send a patch? Plus it would be nice to move i = 0 in > the for loop at the same time. Sadly, Qualcomm policy makes that very cumbersome for me. I won't be able to send a patch any time soon. -- Qualcomm Innovation Cen

Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

2015-01-14 Thread Stephen Boyd
On 01/14/2015 03:38 PM, Timur Tabi wrote: > On Fri, Aug 29, 2014 at 9:30 AM, Pramod Gurav > wrote: >> +static void msm_pinctrl_setup_pm_reset(struct msm_pinctrl *pctrl) >> +{ >> + int i = 0; >> + const struct msm_function *func = pctrl->soc->functions; >> + >> + for (; i <= pctrl

Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

2015-01-14 Thread Timur Tabi
On Fri, Aug 29, 2014 at 9:30 AM, Pramod Gurav wrote: > > +static void msm_pinctrl_setup_pm_reset(struct msm_pinctrl *pctrl) > +{ > + int i = 0; > + const struct msm_function *func = pctrl->soc->functions; > + > + for (; i <= pctrl->soc->nfunctions; i++) Shouldn't this be

Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

2014-09-02 Thread Bjorn Andersson
On Tue 02 Sep 05:36 PDT 2014, Linus Walleij wrote: > A bit dirty to have this in this driver, but who cares. > Indeed, but we figured the taint was small enough to justify not creating cross-references to a separate driver. > Does the APQ8064 accompanying PMIC also have the ability to > complet

Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

2014-09-02 Thread Linus Walleij
On Fri, Aug 29, 2014 at 4:30 PM, Pramod Gurav wrote: > This patch adds support for reset functions to reboot the boards > with soc apq8064. > > CC: Linus Walleij > CC: Bjorn Andersson > CC: "Ivan T. Ivanov" > CC: Stephen Boyd > CC: Andy Gross > Signed-off-by: Pramod Gurav OK patch applied

Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

2014-08-29 Thread Pramod Gurav
Bjorn, Thanks for review. :) On 30-08-2014 12:12 AM, Bjorn Andersson wrote: > On Fri 29 Aug 07:30 PDT 2014, Pramod Gurav wrote: > >> This patch adds support for reset functions to reboot the boards >> with soc apq8064. >> >> CC: Linus Walleij >> CC: Bjorn Andersson >> CC: "Ivan T. Ivanov" >> C

Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

2014-08-29 Thread Bjorn Andersson
On Fri 29 Aug 07:30 PDT 2014, Pramod Gurav wrote: > This patch adds support for reset functions to reboot the boards > with soc apq8064. > > CC: Linus Walleij > CC: Bjorn Andersson > CC: "Ivan T. Ivanov" > CC: Stephen Boyd > CC: Andy Gross > Signed-off-by: Pramod Gurav Thanks for the rewor

[PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

2014-08-29 Thread Pramod Gurav
This patch adds support for reset functions to reboot the boards with soc apq8064. CC: Linus Walleij CC: Bjorn Andersson CC: "Ivan T. Ivanov" CC: Stephen Boyd CC: Andy Gross Signed-off-by: Pramod Gurav --- drivers/pinctrl/qcom/pinctrl-apq8064.c |7 ++- drivers/pinctrl/qcom/pinctrl-m