Re: [PATCH v3 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-08 Thread Hans de Goede
Hi, On 07-08-18 14:46, John Garry wrote: On 07/08/2018 09:05, Hans de Goede wrote: On systems with ACPI instantiated i2c-clients, normally there is 1 fw_node per i2c-device and that fw-node contains 1 I2cSerialBus resource for that 1 i2c-device. But in some rare cases the manufacturer has deci

Re: [PATCH v3 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-08 Thread Hans de Goede
Hi, On 07-08-18 13:45, Andy Shevchenko wrote: On Tue, 2018-08-07 at 13:33 +0200, Hans de Goede wrote: Hi, On 07-08-18 13:27, Wolfram Sang wrote: Hi Hans, +I2C MULTI INSTANTIATE DRIVER In the case below, I think it would be slightly better to mention ACPI here, something like ACPI I2C ...

Re: [PATCH v3 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-07 Thread John Garry
On 07/08/2018 09:05, Hans de Goede wrote: On systems with ACPI instantiated i2c-clients, normally there is 1 fw_node per i2c-device and that fw-node contains 1 I2cSerialBus resource for that 1 i2c-device. But in some rare cases the manufacturer has decided to describe multiple i2c-devices in a s

Re: [PATCH v3 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-07 Thread Andy Shevchenko
On Tue, 2018-08-07 at 13:33 +0200, Hans de Goede wrote: > Hi, > > On 07-08-18 13:27, Wolfram Sang wrote: > > Hi Hans, > > > > > +I2C MULTI INSTANTIATE DRIVER In the case below, I think it would be slightly better to mention ACPI here, something like ACPI I2C ... Otherwise it sounds a bit confu

Re: [PATCH v3 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-07 Thread Hans de Goede
Hi, On 07-08-18 13:27, Wolfram Sang wrote: Hi Hans, +I2C MULTI INSTANTIATE DRIVER +M: Hans de Goede +L: linux-...@vger.kernel.org Since this driver is about FW bugs, I wonder if platform-driver-...@vger.kernel.org isn't the better list here? Ok, fixed for v4. +S: Maintained

Re: [PATCH v3 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-07 Thread Wolfram Sang
Hi Hans, > +I2C MULTI INSTANTIATE DRIVER > +M: Hans de Goede > +L: linux-...@vger.kernel.org Since this driver is about FW bugs, I wonder if platform-driver-...@vger.kernel.org isn't the better list here? > +S: Maintained > +F: drivers/drivers/platform/x86/i2c-multi-instantiate.c I2C p

[PATCH v3 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-07 Thread Hans de Goede
On systems with ACPI instantiated i2c-clients, normally there is 1 fw_node per i2c-device and that fw-node contains 1 I2cSerialBus resource for that 1 i2c-device. But in some rare cases the manufacturer has decided to describe multiple i2c-devices in a single ACPI fwnode with multiple I2cSerialBus