Re: [PATCH v3 4/4] arm64: apply __ro_after_init to some objects

2016-08-15 Thread Mark Rutland
Hi, On Mon, Aug 15, 2016 at 02:53:03PM +0800, Jisheng Zhang wrote: > On Fri, 12 Aug 2016 13:43:45 +0100 Mark Rutland wrote: > > On Fri, Aug 12, 2016 at 04:01:11PM +0800, Jisheng Zhang wrote: > > > diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c > > > index 10ad8ab..c1ff7c2 100644

Re: [PATCH v3 4/4] arm64: apply __ro_after_init to some objects

2016-08-14 Thread Jisheng Zhang
Hi Mark, On Fri, 12 Aug 2016 13:43:45 +0100 Mark Rutland wrote: > Hi, > > There are still a few missing includes as of this patch, and I have a > small nit about one file as commented below. > > Please fix up the includes. > > On Fri, Aug 12, 2016 at 04:01:11PM +0800, Jisheng Zhang wrote: > >

Re: [PATCH v3 4/4] arm64: apply __ro_after_init to some objects

2016-08-12 Thread Mark Rutland
Hi, There are still a few missing includes as of this patch, and I have a small nit about one file as commented below. Please fix up the includes. On Fri, Aug 12, 2016 at 04:01:11PM +0800, Jisheng Zhang wrote: > diff --git a/arch/arm64/kernel/cpu_ops.c b/arch/arm64/kernel/cpu_ops.c > index c7cfb

[PATCH v3 4/4] arm64: apply __ro_after_init to some objects

2016-08-12 Thread Jisheng Zhang
These objects are set during initialization, thereafter are read only. Previously I only want to mark vdso_pages, vdso_spec, vectors_page and cpu_ops as __read_mostly from performance point of view. Then inspired by Kees's patch[1] to apply more __ro_after_init for arm, I think it's better to mark