Re: [PATCH v3 3/6] pwm: mediatek: fix clock control issue

2017-08-21 Thread Thierry Reding
On Fri, Jun 30, 2017 at 02:05:18PM +0800, Zhi Mao wrote: > 1. prepare top/main clk in mtk_pwm_probe() function, >it will increase power consumption >and in original code these clocks is only prepeare but never enabled. > 2. pwm clock should be enabled before setting pwm registers >in fu

[PATCH v3 3/6] pwm: mediatek: fix clock control issue

2017-06-29 Thread Zhi Mao
1. prepare top/main clk in mtk_pwm_probe() function, it will increase power consumption and in original code these clocks is only prepeare but never enabled. 2. pwm clock should be enabled before setting pwm registers in function: mtk_pwm_config(). 3. delete "pwm_disable" in function:mtk_p