Re: [PATCH v3 3/6] blktrace: move blktrace debugfs creation to helper function

2020-05-01 Thread Bart Van Assche
On 2020-04-29 00:46, Luis Chamberlain wrote: > +static struct dentry *blk_trace_debugfs_dir(struct blk_user_trace_setup > *buts, > + struct blk_trace *bt) > +{ > + struct dentry *dir = NULL; > + > + dir = debugfs_lookup(buts->name, blk_debugfs_root);

Re: [PATCH v3 3/6] blktrace: move blktrace debugfs creation to helper function

2020-04-29 Thread Christoph Hellwig
On Wed, Apr 29, 2020 at 07:46:24AM +, Luis Chamberlain wrote: > Move the work to create the debugfs directory used into a helper. > It will make further checks easier to read. This commit introduces > no functional changes. > > Signed-off-by: Luis Chamberlain Looks good, Reviewed-by: Christ

[PATCH v3 3/6] blktrace: move blktrace debugfs creation to helper function

2020-04-29 Thread Luis Chamberlain
Move the work to create the debugfs directory used into a helper. It will make further checks easier to read. This commit introduces no functional changes. Signed-off-by: Luis Chamberlain --- kernel/trace/blktrace.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --