Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-18 Thread Andy Shevchenko
On Mon, May 18, 2020 at 07:05:11PM +0200, Maarten Brock wrote: > On 2020-05-18 18:35, Andy Shevchenko wrote: > > On Mon, May 18, 2020 at 06:13:16PM +0200, Maarten Brock wrote: > > > On 2020-05-18 17:22, Lukas Wunner wrote: > > > > On Mon, May 18, 2020 at 06:12:41PM +0300, Andy Shevchenko wrote: > >

Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-18 Thread Maarten Brock
On 2020-05-18 18:35, Andy Shevchenko wrote: On Mon, May 18, 2020 at 06:13:16PM +0200, Maarten Brock wrote: On 2020-05-18 17:22, Lukas Wunner wrote: > On Mon, May 18, 2020 at 06:12:41PM +0300, Andy Shevchenko wrote: > > On Sun, May 17, 2020 at 11:56:08PM +0200, Heiko Stuebner wrote: > > > From: H

Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-18 Thread Andy Shevchenko
On Mon, May 18, 2020 at 06:13:16PM +0200, Maarten Brock wrote: > On 2020-05-18 17:22, Lukas Wunner wrote: > > On Mon, May 18, 2020 at 06:12:41PM +0300, Andy Shevchenko wrote: > > > On Sun, May 17, 2020 at 11:56:08PM +0200, Heiko Stuebner wrote: > > > > From: Heiko Stuebner > > > > > > > > The RE s

Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-18 Thread Maarten Brock
On 2020-05-18 17:22, Lukas Wunner wrote: On Mon, May 18, 2020 at 06:12:41PM +0300, Andy Shevchenko wrote: On Sun, May 17, 2020 at 11:56:08PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > The RE signal is used to control the duplex mode of transmissions, > aka receiving data while send

Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-18 Thread Lukas Wunner
On Mon, May 18, 2020 at 05:22:47PM +0200, Lukas Wunner wrote: > And for longer cables, users may have to disable it using the > TIOCSRS485 ioctl. Sorry, I meant *enable* here. %-/

Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-18 Thread Lukas Wunner
On Mon, May 18, 2020 at 06:12:41PM +0300, Andy Shevchenko wrote: > On Sun, May 17, 2020 at 11:56:08PM +0200, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > The RE signal is used to control the duplex mode of transmissions, > > aka receiving data while sending in full duplex mode, while st

Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-18 Thread Andy Shevchenko
On Sun, May 17, 2020 at 11:56:08PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > The RE signal is used to control the duplex mode of transmissions, > aka receiving data while sending in full duplex mode, while stopping > receiving data in half-duplex mode. > > On a number of boards the

Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-18 Thread Lukas Wunner
On Mon, May 18, 2020 at 10:04:05AM +0200, Heiko Stübner wrote: > Am Montag, 18. Mai 2020, 06:50:06 CEST schrieb Lukas Wunner: > > On Sun, May 17, 2020 at 11:56:08PM +0200, Heiko Stuebner wrote: > > > @@ -1457,6 +1458,7 @@ void serial8250_em485_stop_tx(struct uart_8250_port > > > *p) > > >* Ena

Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-18 Thread Heiko Stübner
Am Montag, 18. Mai 2020, 06:50:06 CEST schrieb Lukas Wunner: > On Sun, May 17, 2020 at 11:56:08PM +0200, Heiko Stuebner wrote: > > @@ -1457,6 +1458,7 @@ void serial8250_em485_stop_tx(struct uart_8250_port > > *p) > > * Enable previously disabled RX interrupts. > > */ > > if (!(p->por

Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-17 Thread Lukas Wunner
On Sun, May 17, 2020 at 11:56:08PM +0200, Heiko Stuebner wrote: > @@ -1457,6 +1458,7 @@ void serial8250_em485_stop_tx(struct uart_8250_port *p) >* Enable previously disabled RX interrupts. >*/ > if (!(p->port.rs485.flags & SER_RS485_RX_DURING_TX)) { > + gpiod_set_v

[PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-17 Thread Heiko Stuebner
From: Heiko Stuebner The RE signal is used to control the duplex mode of transmissions, aka receiving data while sending in full duplex mode, while stopping receiving data in half-duplex mode. On a number of boards the !RE signal is tied to ground so reception is always enabled except if the UAR