Re: [PATCH v3 3/5] hugetlb: only set HPageMigratable for migratable hstates

2021-02-03 Thread Mike Kravetz
On 2/1/21 3:49 AM, Michal Hocko wrote: > On Fri 29-01-21 10:46:15, Mike Kravetz wrote: >> On 1/28/21 2:15 PM, Andrew Morton wrote: >>> On Thu, 28 Jan 2021 14:00:29 -0800 Mike Kravetz >>> wrote: Michal suggested that comments describing synchronization be added for each flag. Since

Re: [PATCH v3 3/5] hugetlb: only set HPageMigratable for migratable hstates

2021-02-01 Thread Michal Hocko
On Fri 29-01-21 10:46:15, Mike Kravetz wrote: > On 1/28/21 2:15 PM, Andrew Morton wrote: > > On Thu, 28 Jan 2021 14:00:29 -0800 Mike Kravetz > > wrote: > >> > >> Michal suggested that comments describing synchronization be added for each > >> flag. Since I did 'one patch per flag', that would be

Re: [PATCH v3 3/5] hugetlb: only set HPageMigratable for migratable hstates

2021-01-29 Thread Mike Kravetz
On 1/28/21 2:15 PM, Andrew Morton wrote: > On Thu, 28 Jan 2021 14:00:29 -0800 Mike Kravetz > wrote: >> >> Michal suggested that comments describing synchronization be added for each >> flag. Since I did 'one patch per flag', that would be an update to each >> patch. >> Or, I could simply add a

Re: [PATCH v3 3/5] hugetlb: only set HPageMigratable for migratable hstates

2021-01-28 Thread Andrew Morton
On Thu, 28 Jan 2021 14:00:29 -0800 Mike Kravetz wrote: > On 1/28/21 1:37 PM, Andrew Morton wrote: > > On Thu, 28 Jan 2021 06:52:21 +0100 Oscar Salvador wrote: > > > >> On Wed, Jan 27, 2021 at 03:36:41PM -0800, Mike Kravetz wrote: > >>> Yes, this patch is somewhat optional. It should be a minor

Re: [PATCH v3 3/5] hugetlb: only set HPageMigratable for migratable hstates

2021-01-28 Thread Mike Kravetz
On 1/28/21 1:37 PM, Andrew Morton wrote: > On Thu, 28 Jan 2021 06:52:21 +0100 Oscar Salvador wrote: > >> On Wed, Jan 27, 2021 at 03:36:41PM -0800, Mike Kravetz wrote: >>> Yes, this patch is somewhat optional. It should be a minor improvement >>> in cases where we are dealing with hpages in a non

Re: [PATCH v3 3/5] hugetlb: only set HPageMigratable for migratable hstates

2021-01-28 Thread Andrew Morton
On Thu, 28 Jan 2021 06:52:21 +0100 Oscar Salvador wrote: > On Wed, Jan 27, 2021 at 03:36:41PM -0800, Mike Kravetz wrote: > > Yes, this patch is somewhat optional. It should be a minor improvement > > in cases where we are dealing with hpages in a non-migratable hstate. > > Although, I do not bel

Re: [PATCH v3 3/5] hugetlb: only set HPageMigratable for migratable hstates

2021-01-27 Thread Oscar Salvador
On Wed, Jan 27, 2021 at 03:36:41PM -0800, Mike Kravetz wrote: > Yes, this patch is somewhat optional. It should be a minor improvement > in cases where we are dealing with hpages in a non-migratable hstate. > Although, I do not believe this is the common case. > > The real reason for even looking

Re: [PATCH v3 3/5] hugetlb: only set HPageMigratable for migratable hstates

2021-01-27 Thread Mike Kravetz
On 1/27/21 2:35 AM, Michal Hocko wrote: > On Fri 22-01-21 11:52:29, Mike Kravetz wrote: >> The HP_Migratable flag indicates a page is a candidate for migration. >> Only set the flag if the page's hstate supports migration. This allows >> the migration paths to detect non-migratable pages earlier.

Re: [PATCH v3 3/5] hugetlb: only set HPageMigratable for migratable hstates

2021-01-27 Thread Michal Hocko
On Fri 22-01-21 11:52:29, Mike Kravetz wrote: > The HP_Migratable flag indicates a page is a candidate for migration. > Only set the flag if the page's hstate supports migration. This allows > the migration paths to detect non-migratable pages earlier. If migration > is not supported for the hsta

Re: [PATCH v3 3/5] hugetlb: only set HPageMigratable for migratable hstates

2021-01-26 Thread Oscar Salvador
On Fri, Jan 22, 2021 at 11:52:29AM -0800, Mike Kravetz wrote: > The HP_Migratable flag indicates a page is a candidate for migration. > Only set the flag if the page's hstate supports migration. This allows > the migration paths to detect non-migratable pages earlier. If migration > is not suppor

[PATCH v3 3/5] hugetlb: only set HPageMigratable for migratable hstates

2021-01-22 Thread Mike Kravetz
The HP_Migratable flag indicates a page is a candidate for migration. Only set the flag if the page's hstate supports migration. This allows the migration paths to detect non-migratable pages earlier. If migration is not supported for the hstate, HP_Migratable will not be set, the page will not b