Re: [PATCH v3 3/3] x86/asm: Pin sensitive CR0 bits

2019-06-18 Thread Kees Cook
On Tue, Jun 18, 2019 at 02:24:30PM +0200, Peter Zijlstra wrote: > On Tue, Jun 18, 2019 at 11:38:02AM +0200, Jann Horn wrote: > > On Tue, Jun 18, 2019 at 6:55 AM Kees Cook wrote: > > > With sensitive CR4 bits pinned now, it's possible that the WP bit for > > > CR0 might become a target as well. Fol

Re: [PATCH v3 3/3] x86/asm: Pin sensitive CR0 bits

2019-06-18 Thread Peter Zijlstra
On Tue, Jun 18, 2019 at 11:38:02AM +0200, Jann Horn wrote: > On Tue, Jun 18, 2019 at 6:55 AM Kees Cook wrote: > > With sensitive CR4 bits pinned now, it's possible that the WP bit for > > CR0 might become a target as well. Following the same reasoning for > > the CR4 pinning, this pins CR0's WP bi

Re: [PATCH v3 3/3] x86/asm: Pin sensitive CR0 bits

2019-06-18 Thread Jann Horn
On Tue, Jun 18, 2019 at 6:55 AM Kees Cook wrote: > With sensitive CR4 bits pinned now, it's possible that the WP bit for > CR0 might become a target as well. Following the same reasoning for > the CR4 pinning, this pins CR0's WP bit (but this can be done with a > static value). > > Suggested-by: P

[PATCH v3 3/3] x86/asm: Pin sensitive CR0 bits

2019-06-17 Thread Kees Cook
With sensitive CR4 bits pinned now, it's possible that the WP bit for CR0 might become a target as well. Following the same reasoning for the CR4 pinning, this pins CR0's WP bit (but this can be done with a static value). Suggested-by: Peter Zijlstra Signed-off-by: Kees Cook --- arch/x86/includ