Re: [PATCH v3 3/3] s390: convert to GENERIC_VDSO

2020-08-04 Thread Sven Schnelle
Hi Thomas, Thomas Gleixner writes: > Sven Schnelle writes: >> --- /dev/null >> +++ b/arch/s390/include/asm/vdso/data.h >> @@ -0,0 +1,13 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +#ifndef __S390_ASM_VDSO_DATA_H >> +#define __S390_ASM_VDSO_DATA_H >> + >> +#include >> +#include > > I don'

Re: [PATCH v3 3/3] s390: convert to GENERIC_VDSO

2020-08-04 Thread Thomas Gleixner
Sven, Sven Schnelle writes: > --- /dev/null > +++ b/arch/s390/include/asm/vdso/data.h > @@ -0,0 +1,13 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef __S390_ASM_VDSO_DATA_H > +#define __S390_ASM_VDSO_DATA_H > + > +#include > +#include I don't think this header needs vdso/datapage.h >

Re: [PATCH v3 3/3] s390: convert to GENERIC_VDSO

2020-08-04 Thread kernel test robot
Hi Sven, Thank you for the patch! Yet something to improve: [auto build test ERROR on s390/features] [also build test ERROR on tip/timers/core linus/master v5.8 next-20200804] [cannot apply to tip/timers/vdso] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submit

[PATCH v3 3/3] s390: convert to GENERIC_VDSO

2020-08-04 Thread Sven Schnelle
This patch converts s390 to the generic vDSO. There are a few special things on s390: - vDSO can be called without a stack frame - glibc did this in the past. So we need to allocate a stackframe on our own. - The former assembly code used stcke to get the TOD clock and applied time steering t