Re: [PATCH v3 3/3] perf tool: add cgroup identifier entry in perf report

2016-12-14 Thread Eric W. Biederman
Peter Zijlstra writes: > On Wed, Dec 14, 2016 at 08:56:43AM +1300, Eric W. Biederman wrote: >> >> I would just make the identifier a structure containing the >> device number and the inode number. It didn't look like perf required >> the identifier to be a simple integer. > > Right, perf doesn'

Re: [PATCH v3 3/3] perf tool: add cgroup identifier entry in perf report

2016-12-14 Thread Hari Bathini
On Wednesday 14 December 2016 09:22 PM, Eric W. Biederman wrote: Peter Zijlstra writes: On Wed, Dec 14, 2016 at 08:56:43AM +1300, Eric W. Biederman wrote: I would just make the identifier a structure containing the device number and the inode number. It didn't look like perf required the i

Re: [PATCH v3 3/3] perf tool: add cgroup identifier entry in perf report

2016-12-14 Thread Peter Zijlstra
On Wed, Dec 14, 2016 at 08:56:43AM +1300, Eric W. Biederman wrote: > > I would just make the identifier a structure containing the > device number and the inode number. It didn't look like perf required > the identifier to be a simple integer. Right, perf doesn't care at all here, its just a tra

Re: [PATCH v3 3/3] perf tool: add cgroup identifier entry in perf report

2016-12-13 Thread Eric W. Biederman
Hari Bathini writes: > Hi Eric, > > > On Tuesday 13 December 2016 03:36 AM, Eric W. Biederman wrote: >> Hari Bathini writes: >> >>> This patch introduces a cgroup identifier entry field in perf report to >>> identify or distinguish data of different cgroups. It uses the unique >>> inode number o

Re: [PATCH v3 3/3] perf tool: add cgroup identifier entry in perf report

2016-12-13 Thread Hari Bathini
Hi Eric, On Tuesday 13 December 2016 03:36 AM, Eric W. Biederman wrote: Hari Bathini writes: This patch introduces a cgroup identifier entry field in perf report to identify or distinguish data of different cgroups. It uses the unique inode number of cgroup namespace, included in perf data w

Re: [PATCH v3 3/3] perf tool: add cgroup identifier entry in perf report

2016-12-12 Thread Eric W. Biederman
Hari Bathini writes: > This patch introduces a cgroup identifier entry field in perf report to > identify or distinguish data of different cgroups. It uses the unique > inode number of cgroup namespace, included in perf data with the new > PERF_RECORD_NAMESPACES event, as cgroup identifier. With

[PATCH v3 3/3] perf tool: add cgroup identifier entry in perf report

2016-12-12 Thread Hari Bathini
This patch introduces a cgroup identifier entry field in perf report to identify or distinguish data of different cgroups. It uses the unique inode number of cgroup namespace, included in perf data with the new PERF_RECORD_NAMESPACES event, as cgroup identifier. With the assumption that each contai