Re: [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header

2016-02-09 Thread Daniel Wagner
On 02/09/2016 08:44 PM, Maciej W. Rozycki wrote: > On Tue, 9 Feb 2016, Daniel Wagner wrote: > >>> FWIW I think all the MIPS ABI flags stuff also needs to go outside the >>> conditional, because it's ABI agnostic. I'll make the right change myself >>> on top of your fixes. It'll remove a littl

Re: [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header

2016-02-09 Thread Maciej W. Rozycki
On Tue, 9 Feb 2016, Daniel Wagner wrote: > > FWIW I think all the MIPS ABI flags stuff also needs to go outside the > > conditional, because it's ABI agnostic. I'll make the right change myself > > on top of your fixes. It'll remove a little bit of code duplication, > > which is always welco

Re: [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header

2016-02-09 Thread Daniel Wagner
On 02/09/2016 01:32 PM, Maciej W. Rozycki wrote: > FWIW I think all the MIPS ABI flags stuff also needs to go outside the > conditional, because it's ABI agnostic. I'll make the right change myself > on top of your fixes. It'll remove a little bit of code duplication, > which is always welcom

Re: [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header

2016-02-09 Thread Maciej W. Rozycki
On Tue, 9 Feb 2016, Daniel Wagner wrote: > > All error/warnings (new ones prefixed by >>): > > > >arch/mips/kernel/../../../fs/binfmt_elf.c: In function 'load_elf_interp': > >>> arch/mips/kernel/binfmt_elfn32.c:38:7: error: implicit declaration of > >>> function 'mips_elf_check_machine' [-We

Re: [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header

2016-02-09 Thread Daniel Wagner
Hi Maciej, On 02/08/2016 05:22 PM, kbuild test robot wrote: > Hi Daniel, > > [auto build test ERROR on v4.5-rc3] > [also build test ERROR on next-20160208] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > > url: > https://github.com/

Re: [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header

2016-02-08 Thread Maciej W. Rozycki
On Mon, 8 Feb 2016, Daniel Wagner wrote: > Therefore, we rather define vmcore_elf{32|64}_check_arch() as a > basic machine check and use it also in binfm_elf?32.c as well. > > Signed-off-by: Daniel Wagner > Suggested-by: Maciej W. Rozycki > Reported-by: Fengguang Wu > --- Reviewed-by: Maciej

Re: [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header

2016-02-08 Thread kbuild test robot
Hi Daniel, [auto build test ERROR on v4.5-rc3] [also build test ERROR on next-20160208] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Daniel-Wagner/Differentiate-between-32-and-64-bit-ELF-hea

[PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header

2016-02-08 Thread Daniel Wagner
Depending on the configuration either the 32 or 64 bit version of elf_check_arch() is defined. parse_crash_elf{32|64}_headers() does some basic verification of the ELF header via vmcore_elf{32|64}_check_arch() which happen to map to elf_check_arch(). Since the implementation 32 and 64 bit version o