Re: [PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler

2018-10-11 Thread Wolfram Sang
On Mon, Sep 24, 2018 at 04:52:35PM -0700, Stephen Boyd wrote: > We don't need to use goto here, we can just collapse the if statement > and goto chain into multiple branches and then combine some duplicate > completion calls into one big if statement. Let's do it to clean up code > some more. > >

Re: [PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler

2018-10-04 Thread alokc
On 2018-09-26 03:19, Doug Anderson wrote: Hi, On Mon, Sep 24, 2018 at 4:52 PM Stephen Boyd wrote: We don't need to use goto here, we can just collapse the if statement and goto chain into multiple branches and then combine some duplicate completion calls into one big if statement. Let's do i

Re: [PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler

2018-09-25 Thread Doug Anderson
Hi, On Mon, Sep 24, 2018 at 4:52 PM Stephen Boyd wrote: > > We don't need to use goto here, we can just collapse the if statement > and goto chain into multiple branches and then combine some duplicate > completion calls into one big if statement. Let's do it to clean up code > some more. > > Cc:

[PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler

2018-09-24 Thread Stephen Boyd
We don't need to use goto here, we can just collapse the if statement and goto chain into multiple branches and then combine some duplicate completion calls into one big if statement. Let's do it to clean up code some more. Cc: Karthikeyan Ramasubramanian Cc: Sagar Dharia Cc: Girish Mahadevan C