RE: [PATCH v3 3/3] eeprom: at24: enable runtime pm support

2017-08-30 Thread Mohandass, Divagar
ms.de; >devicet...@vger.kernel.org; linux-...@vger.kernel.org; linux- >ker...@vger.kernel.org; Mani, Rajmohan >Subject: Re: [PATCH v3 3/3] eeprom: at24: enable runtime pm support > >On Wed, Aug 30, 2017 at 12:32:07PM +, Mohandass, Divagar wrote: >> >> @@ -743,6 +770,15

Re: [PATCH v3 3/3] eeprom: at24: enable runtime pm support

2017-08-30 Thread Sakari Ailus
On Wed, Aug 30, 2017 at 12:32:07PM +, Mohandass, Divagar wrote: > >> @@ -743,6 +770,15 @@ static int at24_probe(struct i2c_client *client, > >> const struct i2c_device_id *id) > >> > >>i2c_set_clientdata(client, at24); > >> > >> + /* enable runtime pm */ > >> + pm_runtime_get_noresume(&cl

RE: [PATCH v3 3/3] eeprom: at24: enable runtime pm support

2017-08-30 Thread Mohandass, Divagar
ms.de; >devicet...@vger.kernel.org; linux-...@vger.kernel.org; linux- >ker...@vger.kernel.org; Mani, Rajmohan >Subject: Re: [PATCH v3 3/3] eeprom: at24: enable runtime pm support > >Hi Divagar, > >Thanks for the update. A few more comments below. > >On Wed, Aug 30, 2017 at

Re: [PATCH v3 3/3] eeprom: at24: enable runtime pm support

2017-08-30 Thread Sakari Ailus
Hi Divagar, Thanks for the update. A few more comments below. On Wed, Aug 30, 2017 at 09:41:06AM +0530, Divagar Mohandass wrote: > Currently the device is kept in D0, there is an opportunity > to save power by enabling runtime pm. > > Device can be daisy chained from PMIC and we can't rely on I2

[PATCH v3 3/3] eeprom: at24: enable runtime pm support

2017-08-29 Thread Divagar Mohandass
Currently the device is kept in D0, there is an opportunity to save power by enabling runtime pm. Device can be daisy chained from PMIC and we can't rely on I2C core for auto resume/suspend. Driver will decide when to resume/suspend. Signed-off-by: Divagar Mohandass --- drivers/misc/eeprom/at24