Re: [PATCH v3 3/3] arm64: Early boot time stamps

2019-01-04 Thread Pavel Tatashin
> > sched_clock() will still be strictly monotonic. During switch over we > > will guarantee to continue from where the early clock left. > > Not quite. There is at least one broken integration that results in > large, spurious jumps ahead. If one of these jumps happens during the > "unstable" phas

Re: [PATCH v3 3/3] arm64: Early boot time stamps

2019-01-04 Thread Marc Zyngier
On 04/01/2019 16:23, Pavel Tatashin wrote: Hi Pavel, >>> We could limit arm64 approach only for chips where cntvct_el0 is >>> working: i.e. frequency is known, and the clock is stable, meaning >>> cannot go backward. Perhaps we would start early clock a little later, >>> but at least it will be a

Re: [PATCH v3 3/3] arm64: Early boot time stamps

2019-01-04 Thread Pavel Tatashin
Hi Marc, Thank you for taking a look at this please see my replies below. > > I think, given that on other platforms sched_clock() is already used > > early, it is not a good idea to invent a different clock just for time > > stamps. > > Square pegs vs round holes. Mimicking other architectures i

Re: [PATCH v3 3/3] arm64: Early boot time stamps

2019-01-04 Thread Marc Zyngier
On Thu, 03 Jan 2019 19:58:25 +, Pavel Tatashin wrote: > > > I still think this approach is flawed. You provide the kernel with a > > potentially broken sched_clock that may jump back and forth until the > > workaround kicks in. Nobody expects this. > > > > Instead, I'd suggest you allow for a

Re: [PATCH v3 3/3] arm64: Early boot time stamps

2019-01-03 Thread Pavel Tatashin
> I still think this approach is flawed. You provide the kernel with a > potentially broken sched_clock that may jump back and forth until the > workaround kicks in. Nobody expects this. > > Instead, I'd suggest you allow for a something other than local_clock() > to be used for the time stamping u

Re: [PATCH v3 3/3] arm64: Early boot time stamps

2019-01-03 Thread Marc Zyngier
Hi Pavel, On 26/12/2018 16:45, Pavel Tatashin wrote: > Allow printk time stamps/sched_clock() to be available from the early > boot. > > Signed-off-by: Pavel Tatashin > --- > arch/arm64/kernel/setup.c | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm6

[PATCH v3 3/3] arm64: Early boot time stamps

2018-12-26 Thread Pavel Tatashin
Allow printk time stamps/sched_clock() to be available from the early boot. Signed-off-by: Pavel Tatashin --- arch/arm64/kernel/setup.c | 25 + 1 file changed, 25 insertions(+) diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c index 4b0e1231625c..28126fa