Re: [PATCH v3 2/9] net: rds: use this_cpu_ptr per-cpu helper

2012-11-12 Thread Christoph Lameter
On Mon, 12 Nov 2012, Shan Wei wrote: > __percpu annotations in struct rds_ib_refill_cache is missing. > > you mean that read/write fields of struct rds_ib_cache_head > using __this_cpu_* operation like following? > How about it? > > diff --git a/net/rds/ib.h b/net/rds/ib.h > index 8d2b3d5..7280ab8

Re: [PATCH v3 2/9] net: rds: use this_cpu_ptr per-cpu helper

2012-11-12 Thread Shan Wei
Christoph Lameter said, at 2012/11/10 4:09: >> -chp = per_cpu_ptr(cache->percpu, smp_processor_id()); >> +chp = this_cpu_ptr(cache->percpu); >> if (!chp->first) > > if (!__this_cpu_read(cache-0>percpu->first)) > > ? __percpu annotations in struct rds_ib_refill_cache is missing. you

Re: [PATCH v3 2/9] net: rds: use this_cpu_ptr per-cpu helper

2012-11-09 Thread Christoph Lameter
On Fri, 9 Nov 2012, Shan Wei wrote: > net/rds/ib_recv.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c > index 8d19491..a4a5064 100644 > --- a/net/rds/ib_recv.c > +++ b/net/rds/ib_recv.c > @@ -423,7 +423,7 @@ static void rds_ib

[PATCH v3 2/9] net: rds: use this_cpu_ptr per-cpu helper

2012-11-08 Thread Shan Wei
From: Shan Wei Signed-off-by: Shan Wei Reviewed-by: Christoph Lameter --- no changes vs v2. --- net/rds/ib_recv.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c index 8d19491..a4a5064 100644 --- a/net/rds/ib_recv.c +++ b/net/rds/