Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table

2017-04-03 Thread Aaro Koskinen
Hi, On Mon, Apr 03, 2017 at 06:24:39PM -0400, Javier Martinez Canillas wrote: > On 04/03/2017 06:20 PM, Rob Herring wrote: > > On Mon, Apr 03, 2017 at 11:45:14AM -0400, Javier Martinez Canillas wrote: > >> Hello Lee, > >> > >> On 04/03/2017 07:15 AM, Lee Jones wrote: > >> > >> [snip] > >> >

Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table

2017-04-03 Thread Javier Martinez Canillas
Hello Aaro and Tony, On 04/03/2017 06:58 PM, Tony Lindgren wrote: > * Aaro Koskinen [170403 15:56]: >> Hi, >> >> On Mon, Apr 03, 2017 at 06:24:39PM -0400, Javier Martinez Canillas wrote: >>> On 04/03/2017 06:20 PM, Rob Herring wrote: On Mon, Apr 03, 2017 at 11:45:14AM -0400, Javier Martinez

Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table

2017-04-03 Thread Tony Lindgren
* Aaro Koskinen [170403 15:56]: > Hi, > > On Mon, Apr 03, 2017 at 06:24:39PM -0400, Javier Martinez Canillas wrote: > > On 04/03/2017 06:20 PM, Rob Herring wrote: > > > On Mon, Apr 03, 2017 at 11:45:14AM -0400, Javier Martinez Canillas wrote: > > >> Hello Lee, > > >> > > >> On 04/03/2017 07:15 AM

Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table

2017-04-03 Thread Javier Martinez Canillas
[adding OMAP folks to cc list] Hello Rob, On 04/03/2017 06:20 PM, Rob Herring wrote: > On Mon, Apr 03, 2017 at 11:45:14AM -0400, Javier Martinez Canillas wrote: >> Hello Lee, >> >> On 04/03/2017 07:15 AM, Lee Jones wrote: >> >> [snip] >> +static const struct of_device_id retu_of_match

Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table

2017-04-03 Thread Rob Herring
On Mon, Apr 03, 2017 at 11:45:14AM -0400, Javier Martinez Canillas wrote: > Hello Lee, > > On 04/03/2017 07:15 AM, Lee Jones wrote: > > [snip] > > >> > >> +static const struct of_device_id retu_of_match[] = { > >> + { .compatible = "nokia,retu-mfd" }, > >> + { .compatible = "nokia,tahvo-mfd"

Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table

2017-04-03 Thread Javier Martinez Canillas
Hello Lee, On 04/03/2017 07:15 AM, Lee Jones wrote: [snip] >> >> +static const struct of_device_id retu_of_match[] = { >> +{ .compatible = "nokia,retu-mfd" }, >> +{ .compatible = "nokia,tahvo-mfd" }, > > Please drop the "-mfd". > Yes, I also didn't like it but I didn't want to chang

Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table

2017-04-03 Thread Lee Jones
On Sat, 01 Apr 2017, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALI

[PATCH v3 2/7] mfd: retu: Add OF device ID table

2017-04-01 Thread Javier Martinez Canillas
The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could c