Re: [PATCH v3 2/6] i2c: acpi: Use available IRQ helper functions

2019-06-05 Thread Charles Keepax
On Tue, Jun 04, 2019 at 08:00:52PM +0300, Andy Shevchenko wrote: > On Tue, May 28, 2019 at 03:28:56PM +0100, Charles Keepax wrote: > > Use the available IRQ helper functions, most of the functions have > > additional helpful side affects like configuring the trigger type of the > > IRQ. > > > > Y

Re: [PATCH v3 2/6] i2c: acpi: Use available IRQ helper functions

2019-06-04 Thread Andy Shevchenko
On Tue, May 28, 2019 at 03:28:56PM +0100, Charles Keepax wrote: > Use the available IRQ helper functions, most of the functions have > additional helpful side affects like configuring the trigger type of the > IRQ. > You do here two things, i.e. - splitting out helper function - converting it to

Re: [PATCH v3 2/6] i2c: acpi: Use available IRQ helper functions

2019-05-29 Thread Mika Westerberg
On Tue, May 28, 2019 at 03:28:56PM +0100, Charles Keepax wrote: > Use the available IRQ helper functions, most of the functions have > additional helpful side affects like configuring the trigger type of the > IRQ. > > Signed-off-by: Charles Keepax Reviewed-by: Mika Westerberg

[PATCH v3 2/6] i2c: acpi: Use available IRQ helper functions

2019-05-28 Thread Charles Keepax
Use the available IRQ helper functions, most of the functions have additional helpful side affects like configuring the trigger type of the IRQ. Signed-off-by: Charles Keepax --- Changes since v2: - Don't consider zero to be a valid IRQ number Thanks, Charles drivers/i2c/i2c-core-acpi.c | 24