Re: [PATCH v3 2/4] perf callchain: Abstract callchain print function

2015-11-03 Thread Namhyung Kim
Hi Jiri, On Tue, Nov 03, 2015 at 09:40:55AM +0100, Jiri Olsa wrote: > On Tue, Nov 03, 2015 at 04:18:29PM +0900, Namhyung Kim wrote: > > SNIP > > > while (rb_node) { > > - double percent; > > - > > chain = rb_entry(rb_node, struct callchain_node, rb_node); > > -

Re: [PATCH v3 2/4] perf callchain: Abstract callchain print function

2015-11-03 Thread Jiri Olsa
On Tue, Nov 03, 2015 at 04:18:29PM +0900, Namhyung Kim wrote: SNIP > while (rb_node) { > - double percent; > - > chain = rb_entry(rb_node, struct callchain_node, rb_node); > - percent = chain->hit * 100.0 / total_samples; > > - ret = perce

[PATCH v3 2/4] perf callchain: Abstract callchain print function

2015-11-02 Thread Namhyung Kim
This is a preparation to support for printing other type of callchain value like count or period. Cc: Brendan Gregg Signed-off-by: Namhyung Kim --- tools/perf/ui/browsers/hists.c | 8 +--- tools/perf/ui/gtk/hists.c | 8 ++-- tools/perf/ui/stdio/hist.c | 35 +--