Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-24 Thread masonccyang
Hi Miquel, > > > > > > > > > How to make all #CS keep high for NAND to enter > > > > > > > > > low-power standby mode if driver don't use > > "legacy.select_chip()" > > > > > ? > > > > > > > > > > > > > > > > See commit 02b4a52604a4 ("mtd: rawnand: Make ->select_chip() > > > > > optiona

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-24 Thread masonccyang
Hi Boris, > > > > > Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND > > controller > > > > > > > > > > On Tue, 18 Jun 2019 08:14:36 +0200 > > > > > Boris Brezillon wrote: > > > > > > > &

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-19 Thread Boris Brezillon
On Wed, 19 Jun 2019 16:55:52 +0800 masonccy...@mxic.com.tw wrote: > Hi Boris, > > > > > > > > > Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND > controller > > > > > > > > On Tue,

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-19 Thread masonccyang
Hi Boris, > > > > > > Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller > > > > > > On Tue, 18 Jun 2019 08:14:36 +0200 > > > Boris Brezillon wrote: > > > > > > > > > > > > > > >

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-19 Thread masonccyang
Hi Miquel, > > > > > > Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller > > > > > > On Tue, 18 Jun 2019 08:14:36 +0200 > > > Boris Brezillon wrote: > > > > > > > > > > > > > > >

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-19 Thread Boris Brezillon
On Wed, 19 Jun 2019 16:04:43 +0800 masonccy...@mxic.com.tw wrote: > Hi Boris, > > > > > Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller > > > > On Tue, 18 Jun 2019 08:14:36 +0200 > > Boris Brezillon wrote: > > > > >

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-19 Thread Miquel Raynal
Hi Mason, masonccy...@mxic.com.tw wrote on Wed, 19 Jun 2019 16:04:43 +0800: > Hi Boris, > > > > > Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller > > > > On Tue, 18 Jun 2019 08:14:36 +0200 > > Boris Brezillon wrote: > > &g

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-19 Thread masonccyang
Hi Boris, > > Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller > > On Tue, 18 Jun 2019 08:14:36 +0200 > Boris Brezillon wrote: > > > > > > > > > > > > > > > How to make all #CS keep high for NAND to ent

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-18 Thread Boris Brezillon
On Tue, 18 Jun 2019 08:14:36 +0200 Boris Brezillon wrote: > > > > > > > > > > > > How to make all #CS keep high for NAND to enter > > > > > > low-power standby mode if driver don't use "legacy.select_chip()" > > > > > > > > ? > > > > > > > > > > See commit 02b4a52604a4 ("mtd: rawnand:

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-17 Thread Boris Brezillon
Hi Mason, On Tue, 18 Jun 2019 09:24:14 +0800 masonccy...@mxic.com.tw wrote: > Hi Miquel, > > > > > > > > > > > > +static void mxic_nand_select_chip(struct nand_chip *chip, > int > > > > > > > > chipnr) > > > > > > > > > > > > > > > > _select_target() is preferred now > > > > > >

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-17 Thread masonccyang
Hi Miquel, > > > > > > > > > +static void mxic_nand_select_chip(struct nand_chip *chip, int > > > > > > chipnr) > > > > > > > > > > > > > > _select_target() is preferred now > > > > > > > > > > > > Do you mean I implement mxic_nand_select_target() to control #CS ? > > > > > > > > > > >

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-17 Thread Miquel Raynal
Hi Mason, masonccy...@mxic.com.tw wrote on Wed, 29 May 2019 11:12:08 +0800: > Hi Miquel, > > > > > > > > +static void mxic_nand_select_chip(struct nand_chip *chip, int > > > > chipnr) > > > > > > > > > > > > _select_target() is preferred now > > > > > > > > > > Do you mean I impleme

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-05-28 Thread masonccyang
Hi Miquel, > > > > > > +static void mxic_nand_select_chip(struct nand_chip *chip, int > > chipnr) > > > > > > > > > > _select_target() is preferred now > > > > > > > > Do you mean I implement mxic_nand_select_target() to control #CS ? > > > > > > > > If so, I need to call mxic_nand_selec

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-05-27 Thread Miquel Raynal
Hi Mason, masonccy...@mxic.com.tw wrote on Thu, 23 May 2019 16:58:02 +0800: > Hi Miquel, > > > > > > > > > + > > > > > +static void mxic_nand_select_chip(struct nand_chip *chip, int > chipnr) > > > > > > > > _select_target() is preferred now > > > > > > Do you mean I implement mxic_n

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-05-23 Thread masonccyang
Hi Miquel, > > > > > > + > > > > +static void mxic_nand_select_chip(struct nand_chip *chip, int chipnr) > > > > > > _select_target() is preferred now > > > > Do you mean I implement mxic_nand_select_target() to control #CS ? > > > > If so, I need to call mxic_nand_select_target( ) to cont

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-05-20 Thread Miquel Raynal
Hi Mason, masonccy...@mxic.com.tw wrote on Fri, 17 May 2019 17:30:21 +0800: > Hi Miquel, > > > > + > > > +static void mxic_nand_select_chip(struct nand_chip *chip, int chipnr) > > > > _select_target() is preferred now > > Do you mean I implement mxic_nand_select_target() to control #CS ? >

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-05-17 Thread masonccyang
Hi Miquel, > > + > > +static void mxic_nand_select_chip(struct nand_chip *chip, int chipnr) > > _select_target() is preferred now Do you mean I implement mxic_nand_select_target() to control #CS ? If so, I need to call mxic_nand_select_target( ) to control #CS ON and then #CS OFF in _exec_op(

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-05-15 Thread Miquel Raynal
Hi masonccy...@mxic.com.tw, masonccy...@mxic.com.tw wrote on Wed, 15 May 2019 16:48:46 +0800: > Hi Miquel, > > > > +// SPDX-License-Identifier: GPL-2.0 > > > +// > > > +// Copyright (C) 2019 Macronix International Co., Ltd. > > > +// > > > +// Authors: > > > +// Mason Yang > > > +// zhengxu

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-05-15 Thread masonccyang
Hi Miquel, Sorry, previous email missed this mxic_nand_data_xfer() reply. This Flash Memory Controller implemented the Buffer read-write data transfer for SPI mode and raw NAND mode. That is each time driver write to the transmit of the TXD port and the data is shifted out, new data is rec

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-05-15 Thread masonccyang
Hi Miquel, > > +// SPDX-License-Identifier: GPL-2.0 > > +// > > +// Copyright (C) 2019 Macronix International Co., Ltd. > > +// > > +// Authors: > > +// Mason Yang > > +// zhengxunli > > This is not a valid name. > > Also if he appears here I suppose he should be credited in the > module

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-05-12 Thread Miquel Raynal
Hi Mason, Mason Yang wrote on Mon, 15 Apr 2019 17:23:52 +0800: > Add a driver for Macronix MX25F0A NAND controller. > > Signed-off-by: Mason Yang > --- > drivers/mtd/nand/raw/Kconfig | 6 + > drivers/mtd/nand/raw/Makefile| 1 + > drivers/mtd/nand/raw/mxic_nand.c | 294 > +

[PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-04-15 Thread Mason Yang
Add a driver for Macronix MX25F0A NAND controller. Signed-off-by: Mason Yang --- drivers/mtd/nand/raw/Kconfig | 6 + drivers/mtd/nand/raw/Makefile| 1 + drivers/mtd/nand/raw/mxic_nand.c | 294 +++ 3 files changed, 301 insertions(+) create mode 100