Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation

2017-06-20 Thread Yury Norov
On Mon, Jun 19, 2017 at 06:43:48PM +0100, Russell King - ARM Linux wrote: > On Mon, Jun 19, 2017 at 06:18:18PM +0300, Yury Norov wrote: > > One else thing I forgot to ask - now you have the generic > > implementation for fncpy(), so do you really need to save arm > > version of it? > > This was co

Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation

2017-06-20 Thread Yury Norov
On Mon, Jun 19, 2017 at 01:58:53PM -0700, Florian Fainelli wrote: > On 06/18/2017 04:51 PM, Yury Norov wrote: > > Hi Florian, > > > > Some questions and thoughts inline. > > > > Yury > > > > On Fri, Jun 16, 2017 at 05:07:42PM -0700, Florian Fainelli wrote: > >> Define a generic fncpy() implement

Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation

2017-06-19 Thread Florian Fainelli
On 06/18/2017 04:51 PM, Yury Norov wrote: > Hi Florian, > > Some questions and thoughts inline. > > Yury > > On Fri, Jun 16, 2017 at 05:07:42PM -0700, Florian Fainelli wrote: >> Define a generic fncpy() implementation largely based on the ARM version >> that requires an 8 bytes alignment for the

Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation

2017-06-19 Thread Russell King - ARM Linux
On Mon, Jun 19, 2017 at 06:18:18PM +0300, Yury Norov wrote: > One else thing I forgot to ask - now you have the generic > implementation for fncpy(), so do you really need to save arm > version of it? This was covered in the review of v1, which took the ARM version and incorrectly used it as an as

Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation

2017-06-19 Thread Florian Fainelli
On 06/19/2017 08:18 AM, Yury Norov wrote: > On Mon, Jun 19, 2017 at 02:51:08AM +0300, Yury Norov wrote: >> Hi Florian, >> >> Some questions and thoughts inline. >> >> Yury >> >> On Fri, Jun 16, 2017 at 05:07:42PM -0700, Florian Fainelli wrote: >>> Define a generic fncpy() implementation largely bas

Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation

2017-06-19 Thread Yury Norov
On Mon, Jun 19, 2017 at 02:51:08AM +0300, Yury Norov wrote: > Hi Florian, > > Some questions and thoughts inline. > > Yury > > On Fri, Jun 16, 2017 at 05:07:42PM -0700, Florian Fainelli wrote: > > Define a generic fncpy() implementation largely based on the ARM version > > that requires an 8 byt

Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation

2017-06-18 Thread Yury Norov
> > +/* > > + * Minimum alignment requirement for the source and destination addresses > > + * for function copying. > > + */ > > +#define FNCPY_ALIGN 8 > > >From now this is not arm-only, and it's possible that some architectures > might want to redefine it in their arch/xxx/include/asm/fncpy.h f

Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation

2017-06-18 Thread Yury Norov
Hi Florian, Some questions and thoughts inline. Yury On Fri, Jun 16, 2017 at 05:07:42PM -0700, Florian Fainelli wrote: > Define a generic fncpy() implementation largely based on the ARM version > that requires an 8 bytes alignment for the destination address where to > copy this function as well

[PATCH v3 2/4] asm-generic: Provide a fncpy() implementation

2017-06-16 Thread Florian Fainelli
Define a generic fncpy() implementation largely based on the ARM version that requires an 8 bytes alignment for the destination address where to copy this function as well as the function's own address. Signed-off-by: Florian Fainelli --- include/asm-generic/fncpy.h | 93