Re: [PATCH v3 2/4] ASoC: rockchip: Add rockchip SPDIF transceiver driver

2015-08-19 Thread Heiko Stuebner
Hi Sjoerd, Am Mittwoch, 19. August 2015, 08:56:48 schrieb Sjoerd Simons: > Hey Heiko, > > Thanks for the comments, i'm hoping to address them and Marks comments > in a next patch series next week. > > On Tue, 2015-08-18 at 20:25 +0200, Heiko Stuebner wrote: > > > + > > > + spdif->hclk = devm

Re: [PATCH v3 2/4] ASoC: rockchip: Add rockchip SPDIF transceiver driver

2015-08-18 Thread Sjoerd Simons
Hey Heiko, Thanks for the comments, i'm hoping to address them and Marks comments in a next patch series next week. On Tue, 2015-08-18 at 20:25 +0200, Heiko Stuebner wrote: > > + > > + spdif->hclk = devm_clk_get(&pdev->dev, "spdif_hclk"); > I guess this could be named just "hclk" - as it is

Re: [PATCH v3 2/4] ASoC: rockchip: Add rockchip SPDIF transceiver driver

2015-08-18 Thread Heiko Stuebner
Hi Sjoerd, > +static int rk_spdif_probe(struct platform_device *pdev) > +{ > + struct rk_spdif_dev *spdif; > + struct resource *res; > + void __iomem *regs; > + int ret; > + > + spdif = devm_kzalloc(&pdev->dev, sizeof(*spdif), GFP_KERNEL); > + if (!spdif) > + r

Re: [PATCH v3 2/4] ASoC: rockchip: Add rockchip SPDIF transceiver driver

2015-08-07 Thread Mark Brown
On Fri, Aug 07, 2015 at 01:44:12PM +0200, Sjoerd Simons wrote: > Changes in v2: > - Remove platform: module alias as it was unused Ugh, I see Paul Bolle replied to one of your earlier patches :/ Please just ignore him, he doesn't understand that we don't require machine definitions to be in tree

[PATCH v3 2/4] ASoC: rockchip: Add rockchip SPDIF transceiver driver

2015-08-07 Thread Sjoerd Simons
Add a driver for the SPDIF transceiver available on RK3066, RK3188 and RK3288. Heavily based on the rockchip i2s driver. Signed-off-by: Sjoerd Simons --- Changes in v3: - Fix typos in commit message Changes in v2: - Remove platform: module alias as it was unused - Call MODULE_DEVICE_TABLE(of, )