Re: [PATCH v3 2/3 RESEND] acpi : prevent cpu from becoming online

2012-07-12 Thread Yasuaki Ishimatsu
Hi Toshi, 2012/07/13 1:49, Toshi Kani wrote: On Thu, 2012-07-12 at 20:40 +0900, Yasuaki Ishimatsu wrote: Even if acpi_processor_handle_eject() offlines cpu, there is a chance to online the cpu after that. So the patch closes the window by using get/put_online_cpus(). Why does the patch change

Re: [PATCH v3 2/3 RESEND] acpi : prevent cpu from becoming online

2012-07-12 Thread Yasuaki Ishimatsu
2012/07/12 21:41, Srivatsa S. Bhat wrote: > On 07/12/2012 05:10 PM, Yasuaki Ishimatsu wrote: >> Even if acpi_processor_handle_eject() offlines cpu, there is a chance >> to online the cpu after that. So the patch closes the window by using >> get/put_online_cpus(). >> >> Why does the patch change _c

Re: [PATCH v3 2/3 RESEND] acpi : prevent cpu from becoming online

2012-07-12 Thread Toshi Kani
On Thu, 2012-07-12 at 20:40 +0900, Yasuaki Ishimatsu wrote: > Even if acpi_processor_handle_eject() offlines cpu, there is a chance > to online the cpu after that. So the patch closes the window by using > get/put_online_cpus(). > > Why does the patch change _cpu_up() logic? > > The patch cares t

Re: [PATCH v3 2/3 RESEND] acpi : prevent cpu from becoming online

2012-07-12 Thread Srivatsa S. Bhat
On 07/12/2012 05:10 PM, Yasuaki Ishimatsu wrote: > Even if acpi_processor_handle_eject() offlines cpu, there is a chance > to online the cpu after that. So the patch closes the window by using > get/put_online_cpus(). > > Why does the patch change _cpu_up() logic? > > The patch cares the race of

[PATCH v3 2/3 RESEND] acpi : prevent cpu from becoming online

2012-07-12 Thread Yasuaki Ishimatsu
Even if acpi_processor_handle_eject() offlines cpu, there is a chance to online the cpu after that. So the patch closes the window by using get/put_online_cpus(). Why does the patch change _cpu_up() logic? The patch cares the race of hot-remove cpu and _cpu_up(). If the patch does not change it,