Hi Daniel/Steven,
On 30 August 2016 at 20:32, Daniel Wagner wrote:
> On 08/30/2016 04:20 PM, Daniel Wagner wrote:
>> Just setting the size of the type is not enough. The hist_field_*
>> getter function want to know the offset too:
>
> With this hack here it should work. The COMM generic field is
On Tue, 30 Aug 2016 17:02:03 +0200
Daniel Wagner wrote:
> On 08/30/2016 04:20 PM, Daniel Wagner wrote:
> > Just setting the size of the type is not enough. The hist_field_*
> > getter function want to know the offset too:
>
> With this hack here it should work. The COMM generic field is handl
On 08/30/2016 04:20 PM, Daniel Wagner wrote:
> Just setting the size of the type is not enough. The hist_field_*
> getter function want to know the offset too:
With this hack here it should work. The COMM generic field is handled via
the tracing_map_ops. We could do it also there but than we need
On 08/30/2016 04:01 PM, Daniel Wagner wrote:
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 03c0a48..ab8958f 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -152,7 +152,8 @@ EXPORT_SYMBOL_GPL(trace_define_field);
>
> #define _
Hi Steven,
>> 'hist:key=ltype,latency:val=hitcount:sort=latency if cpu==1'
>
> What about using "CPU" (all caps)? Look at
> kernel/trace/trace_events_filter.c for FILTER_CPU.
>
> Lets not add fields when we can fix the generic code to process these.
Well at least the size info needs to be added
On Tue, 30 Aug 2016 15:11:26 +0530
Binoy Jayan wrote:
> On 29 August 2016 at 15:13, Daniel Wagner wrote:
> > Hi Binoy,
> >
> > Some minor nitpicking.
> >
> > As Steven already pointed out, the cpu field is available in all traces.
> > It's one of the predefined fields (see
> > kernel/trace/trace
On 29 August 2016 at 15:13, Daniel Wagner wrote:
> Hi Binoy,
>
> Some minor nitpicking.
>
> As Steven already pointed out, the cpu field is available in all traces.
> It's one of the predefined fields (see
> kernel/trace/trace_events.c/trace_define_generic_fields()). Just drop it.
>
Hi Daniel,
T
Hi Binoy,
Some minor nitpicking.
On 08/29/2016 08:55 AM, Binoy Jayan wrote:
+DECLARE_EVENT_CLASS(latency_template,
+ TP_PROTO(int ltype, int cpu, cycles_t latency),
+
+ TP_ARGS(ltype, cpu, latency),
+
+ TP_STRUCT__entry(
+ __field(int,ltype)
+
This work is based on work by Daniel Wagner. A few tracepoints are added
at the end of the critical section. With the hist trigger in place, the
hist trigger plots may be generated, with per-cpu breakdown of events
captured. It is based on linux kernel's event infrastructure.
The following filter(
9 matches
Mail list logo
