Re: [PATCH v3 2/3] mm, slub: don't combine pr_err with INFO

2021-02-08 Thread Miaohe Lin
On 2021/2/8 18:14, Yafang Shao wrote: > It is strange to combine "pr_err" with "INFO", so let's remove the > prefix completely. > This patch is motivated by David's comment[1]. > > - before the patch > [ 8846.517809] INFO: Slab 0xf42a2c60 objects=33 used=3 > fp=0x60d32ca8 flags=0x

Re: [PATCH v3 2/3] mm, slub: don't combine pr_err with INFO

2021-02-08 Thread Vlastimil Babka
On 2/8/21 6:26 PM, Matthew Wilcox wrote: > On Mon, Feb 08, 2021 at 06:14:38PM +0800, Yafang Shao wrote: >> It is strange to combine "pr_err" with "INFO", so let's remove the >> prefix completely. > > So is this the right thing to do? Should it be pr_info() instead? > Many of these messages do not

Re: [PATCH v3 2/3] mm, slub: don't combine pr_err with INFO

2021-02-08 Thread Matthew Wilcox
On Mon, Feb 08, 2021 at 06:14:38PM +0800, Yafang Shao wrote: > It is strange to combine "pr_err" with "INFO", so let's remove the > prefix completely. So is this the right thing to do? Should it be pr_info() instead? Many of these messages do not appear to be error messages, but rather informatio

Re: [PATCH v3 2/3] mm, slub: don't combine pr_err with INFO

2021-02-08 Thread Vlastimil Babka
On 2/8/21 11:14 AM, Yafang Shao wrote: > It is strange to combine "pr_err" with "INFO", so let's remove the > prefix completely. > This patch is motivated by David's comment[1]. > > - before the patch > [ 8846.517809] INFO: Slab 0xf42a2c60 objects=33 used=3 > fp=0x60d32ca8 flags=0

[PATCH v3 2/3] mm, slub: don't combine pr_err with INFO

2021-02-08 Thread Yafang Shao
It is strange to combine "pr_err" with "INFO", so let's remove the prefix completely. This patch is motivated by David's comment[1]. - before the patch [ 8846.517809] INFO: Slab 0xf42a2c60 objects=33 used=3 fp=0x60d32ca8 flags=0x17c0010200(slab|head) - after the patch [ 6343.