Re: [f2fs-dev] [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support

2020-12-18 Thread Jaegeuk Kim
On 12/18, Satya Tangirala wrote: > On Tue, Dec 08, 2020 at 04:15:54PM +0800, Robin Hsu wrote: > > From: Robin Hsu > > > > Add F2FS compression support for sload > > * Support file extension filter, either default-accept or default-deny > > policy > > * Support choice of compression algorithm, L

Re: [f2fs-dev] [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support

2020-12-18 Thread Satya Tangirala
On Tue, Dec 08, 2020 at 04:15:54PM +0800, Robin Hsu wrote: > From: Robin Hsu > > Add F2FS compression support for sload > * Support file extension filter, either default-accept or default-deny > policy > * Support choice of compression algorithm, LZO (version 2) or LZ4 > (default) > * Support

Re: [f2fs-dev] [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support

2020-12-10 Thread Jaegeuk Kim
Chao and Robin, I refactored the patch to modify the names and structures. Please take a look at this. https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/commit/?h=dev&id=5cd8e5fcc79611c0692f18c7e7e13d6b4742d3c0 On 12/10, Jaegeuk Kim wrote: > On 12/10, 徐瑞斌 wrote: > > Hi, Jaege

Re: [f2fs-dev] [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support

2020-12-10 Thread Jaegeuk Kim
On 12/10, 徐瑞斌 wrote: > Hi, Jaegeuk, > > I comment here the patch your provided (3 parts, since the patch contains 3 > fixes): > 1. + dn->data_blkaddr = blkaddr; > ret = reserve_new_block(sbi, &dn->data_blkaddr, &sum, type, 0); > > We cannot assign dn->data_blkaddr here. The old on

Re: [f2fs-dev] [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support

2020-12-10 Thread Chao Yu
On 2020/12/8 16:15, Robin Hsu wrote: From: Robin Hsu Add F2FS compression support for sload * Support file extension filter, either default-accept or default-deny policy * Support choice of compression algorithm, LZO (version 2) or LZ4 (default) * Support custom log of cluster size * Supp

Re: [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support

2020-12-08 Thread Jaegeuk Kim
Hi Robin, I found some bugs and want to suggest a fix. I'll apply this on your patch and let me know, if you want to modify more on top of this. --- a/fsck/segment.c +++ b/fsck/segment.c @@ -115,6 +115,8 @@ int new_data_block(struct f2fs_sb_info *sbi, void *block, get_node_info(sbi, dn->

[PATCH v3 2/3] f2fs-tools:sload.f2fs compression support

2020-12-08 Thread Robin Hsu
From: Robin Hsu Add F2FS compression support for sload * Support file extension filter, either default-accept or default-deny policy * Support choice of compression algorithm, LZO (version 2) or LZ4 (default) * Support custom log of cluster size * Support minimum number of compressed blocks p