Re: [PATCH v3 2/2] slab: __GFP_ZERO is incompatible with a constructor

2018-08-04 Thread Guenter Roeck
On 08/04/2018 02:28 AM, Geert Uytterhoeven wrote: On Sat, Aug 4, 2018 at 12:34 AM Matthew Wilcox wrote: On Fri, Aug 03, 2018 at 02:22:57PM -0700, Guenter Roeck wrote: On Thu, Apr 12, 2018 at 12:13:22PM -0700, Matthew Wilcox wrote: From: Matthew Wilcox __GFP_ZERO requests that the object be i

Re: [PATCH v3 2/2] slab: __GFP_ZERO is incompatible with a constructor

2018-08-04 Thread Geert Uytterhoeven
On Sat, Aug 4, 2018 at 12:34 AM Matthew Wilcox wrote: > On Fri, Aug 03, 2018 at 02:22:57PM -0700, Guenter Roeck wrote: > > On Thu, Apr 12, 2018 at 12:13:22PM -0700, Matthew Wilcox wrote: > > > From: Matthew Wilcox > > > __GFP_ZERO requests that the object be initialised to all-zeroes, > > > while

Re: [PATCH v3 2/2] slab: __GFP_ZERO is incompatible with a constructor

2018-08-03 Thread Matthew Wilcox
On Fri, Aug 03, 2018 at 02:22:57PM -0700, Guenter Roeck wrote: > Hi, > > On Thu, Apr 12, 2018 at 12:13:22PM -0700, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > __GFP_ZERO requests that the object be initialised to all-zeroes, > > while the purpose of a constructor is to initialise an o

Re: [PATCH v3 2/2] slab: __GFP_ZERO is incompatible with a constructor

2018-08-03 Thread Guenter Roeck
Hi, On Thu, Apr 12, 2018 at 12:13:22PM -0700, Matthew Wilcox wrote: > From: Matthew Wilcox > > __GFP_ZERO requests that the object be initialised to all-zeroes, > while the purpose of a constructor is to initialise an object to a > particular pattern. We cannot do both. Add a warning to catch

Re: [PATCH v3 2/2] slab: __GFP_ZERO is incompatible with a constructor

2018-04-16 Thread Christopher Lameter
On Thu, 12 Apr 2018, Matthew Wilcox wrote: > __GFP_ZERO requests that the object be initialised to all-zeroes, > while the purpose of a constructor is to initialise an object to a > particular pattern. We cannot do both. Add a warning to catch any > users who mistakenly pass a __GFP_ZERO flag wh

[PATCH v3 2/2] slab: __GFP_ZERO is incompatible with a constructor

2018-04-12 Thread Matthew Wilcox
From: Matthew Wilcox __GFP_ZERO requests that the object be initialised to all-zeroes, while the purpose of a constructor is to initialise an object to a particular pattern. We cannot do both. Add a warning to catch any users who mistakenly pass a __GFP_ZERO flag when allocating a slab with a c